Feature/test

.github/ISSUE_TEMPLATE/read-this-for-all-support-and-questions.md

@@ -0,0 +1,15 @@
+---
+name: READ THIS FOR ALL SUPPORT AND QUESTIONS
+about: 'GO HERE: http://sfdc.co/npchub'
+title: ''
+labels: invalid
+assignees: ''
+
+---
+
+==== IMPORTANT NOTES ====
+
+The Nonprofit Success Pack team does not review or respond to support requests or questions posted in this repository.
+
+Instead, please post all questions and issues directly in the Nonprofit Hub of the Trailblazer Community: http://sfdc.co/npchub
+========================================================================

.gitignore

@@ -30,6 +30,7 @@ Referenced Packages
 *.sublime-project
 *.sublime-workspace
 **/.sfdx/
+**/.sf/
 **/.vscode/
 **/.idea/
 **/.mypy_cache/
@@ -42,7 +43,8 @@ robot/Cumulus/results/
 datasets/dev_org/test_data.db
 *.db
 .cci
-
+.sfdx
+.sf
 # LWC
 force-app/main/default/lwc/.eslintrc.json
 /node_modules

README.md

@@ -1,20 +1,36 @@
 ![Salesforce Nonprofit Success Pack](https://cloud.githubusercontent.com/assets/450473/18836784/15e1774a-83c7-11e6-8434-0521d4fbebc0.png "Salesforce Nonprofit Success Pack")
 
-#### For Users
+## Important Note
 
-* <a href="https://trailhead.salesforce.com/trailblazer-community/groups/0F94S000000kHitSAE?tab=discussion&sort=LAST_MODIFIED_DATE_DESC" target="_blank">Ask questions or get help</a>
-* <a href="https://github.com/SalesforceFoundation/NPSP/issues/new" target="_blank">Log a confirmed Issue</a> or <a href="https://ideas.salesforce.com/s/search#t=All&sort=relevancy" target="_blank">Feature Request</a>
-* <a href="https://powerofus.force.com/NPSP_Documentation" target="_blank">User Documentation</a>
-* Check out existing <a href="https://github.com/SalesforceFoundation/NPSP/labels/bug" target="_blank">bugs</a> and <a href="https://ideas.salesforce.com/s/search#t=All&sort=relevancy&f:@sfcategoryfull=[Nonprofit%7CNonprofit%20Success%20Pack]" target="_blank">feature and enhancement requests.</a>
-* <a href="https://github.com/SalesforceFoundation/NPSP/releases" target="_blank">Release Notes and Beta Releases</a>
+In 2023, Salesforce launched the Nonprofit Cloud which is at the foundation of Salesforce for Nonprofits. Nonprofit Cloud helps teams unify their data to work beyond silos and better collaborate, share, learn from, and use their data. Use Nonprofit Cloud as your a single solution to begin or continue in your digital transformation journey.  Read more about the [new Nonprofit Cloud](https://www.salesforce.com/blog/new-nonprofit-cloud/). Some key highlights:
+
+* Salesforce will to continue support our managed package products, including the Nonprofit Success Pack. Tens of thousands of customers use our current managed package products to achieve great results. 
+* Many of our ISV partners are building fantastic solutions for our managed packages as well as the new Nonprofit Cloud. We’re working with these partners to ensure that they understand our new product architecture, and are able to bring their years of experience and learnings to the new Nonprofit Cloud.
+* Salesforce remains deeply committed to nonprofit pricing. There are many new capabilities within the new Nonprofit Cloud and we work hard to maintain our nonprofit discounts across the new products. Our goals are to simplify access to nonprofit technology and make it easier for customers to get started.
+* Salesforce continues to grant free licenses with the Power of Us Program for the managed packages and Nonprofit Cloud. With Nonprofit Cloud, the Power of Us program also includes more features than ever to accelerate and deepen the nonprofit experience.
+* Take the new product for a test drive. Sign-up for a [Nonprofit Cloud Trial org](https://help.salesforce.com/s/articleView?id=sfdo.NPC_Create_Nonprofit_Cloud_Trial_Org.htm&type=5).
+* Visit the [Nonprofit Hub](https://trailhead.salesforce.com/trailblazer-community/groups/0F9300000001ocxCAA?tab=discussion&sort=LAST_MODIFIED_DATE_DESC) to chat with others about how nonprofits use Salesforce for social good.
+
+---
+### For Nonprofit Success Pack Users and admins
+
+* Check out existing [Nonprofit feature and enhancement requests](https://ideas.salesforce.com/s/search#t=All&sort=relevancy&f:@sfcategoryfull=[Nonprofit%7CNonprofit%20Cloud,Nonprofit%7CNonprofit%20Success%20Pack%20(NPSP)%20-%20Managed%20Package]).
+* [Ask questions or get help with the Nonprofit Success Pack](https://trailhead.salesforce.com/trailblazer-community/groups/0F94S000000kHitSAE)
+* [Ask for support or questions with other Nonprofit Users and Partners](https://trailhead.salesforce.com/trailblazer-community/groups/0F9300000001ocxCAA)
+* [Nonprofit Success Pack (NPSP) Documentation](https://help.salesforce.com/s/articleView?id=sfdo.Nonprofit_Success_Pack.htm)
+* [Release Notes](https://sfdc.co/bnL4Cb)
+* [Known Issues](https://issues.salesforce.com/#f[sfcategoryfull]=Nonprofit%7CNonprofit%20Success%20Pack%20(NPSP)%20-%20Managed%20Package)
+
+###  Try out the Nonprofit Success Pack
 
-#### Try it out
 You can install NPSP utilizing our custom application installer into any Developer Edition, Sandbox or Enterprise Edition Salesforce org.
-* <a href="https://install.salesforce.org/products/npsp" target="_blank">NPSP Installer</a>
 
-#### Meta
+* [NPSP Installer](https://install.salesforce.org/products/npsp)
+
+### Try out the New Nonprofit Cloud
+
+* [Nonprofit Cloud Learning Org Signup](https://help.salesforce.com/s/articleView?id=sfdo.NPC_Create_Nonprofit_Cloud_Trial_Org.htm&type=5)
 
-The Nonprofit Success Pack (“NPSP”) is an open-source package licensed by Salesforce.org (“SFDO”) under the BSD-3 Clause License, found at https://opensource.org/licenses/BSD-3-Clause. ANY MASTER SUBSCRIPTION AGREEMENT YOU OR YOUR ENTITY MAY HAVE WITH SFDO DOES NOT APPLY TO YOUR USE OF NPSP. NPSP IS PROVIDED “AS IS” AND AS AVAILABLE, AND SFDO MAKES NO WARRANTY OF ANY KIND REGARDING NPSP, WHETHER EXPRESS, IMPLIED, STATUTORY OR OTHERWISE, INCLUDING BUT NOT LIMITED TO ANY IMPLIED WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE, FREEDOM FROM DEFECTS OR NON-INFRINGEMENT, TO THE MAXIMUM EXTENT PERMITTED BY APPLICABLE LAW.
-SFDO WILL HAVE NO LIABILITY ARISING OUT OF OR RELATED TO YOUR USE OF NPSP FOR ANY DIRECT DAMAGES OR FOR ANY LOST PROFITS, REVENUES, GOODWILL OR INDIRECT, SPECIAL, INCIDENTAL, CONSEQUENTIAL, EXEMPLARY, COVER, BUSINESS INTERRUPTION OR PUNITIVE DAMAGES, WHETHER AN ACTION IS IN CONTRACT OR TORT AND REGARDLESS OF THE THEORY OF LIABILITY, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGES OR IF A REMEDY OTHERWISE FAILS OF ITS ESSENTIAL PURPOSE. THE FOREGOING DISCLAIMER WILL NOT APPLY TO THE EXTENT PROHIBITED BY LAW. SFDO DISCLAIMS ALL LIABILITY AND INDEMNIFICATION OBLIGATIONS FOR ANY HARM OR DAMAGES CAUSED BY ANY THIRD-PARTY HOSTING PROVIDERS.
+### Meta
 
-_ducking-octo-happiness, laughing-archer_
+The Nonprofit Success Pack (“NPSP”) is an open-source package licensed by Salesforce.org (“SFDO”) under the BSD-3 Clause License, found at https://opensource.org/licenses/BSD-3-Clause. ANY MASTER SUBSCRIPTION AGREEMENT YOU OR YOUR ENTITY MAY HAVE WITH SFDO DOES NOT APPLY TO YOUR USE OF NPSP. NPSP IS PROVIDED “AS IS” AND AS AVAILABLE, AND SFDO MAKES NO WARRANTY OF ANY KIND REGARDING NPSP, WHETHER EXPRESS, IMPLIED, STATUTORY OR OTHERWISE, INCLUDING BUT NOT LIMITED TO ANY IMPLIED WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE, FREEDOM FROM DEFECTS OR NON-INFRINGEMENT, TO THE MAXIMUM EXTENT PERMITTED BY APPLICABLE LAW. SFDO WILL HAVE NO LIABILITY ARISING OUT OF OR RELATED TO YOUR USE OF NPSP FOR ANY DIRECT DAMAGES OR FOR ANY LOST PROFITS, REVENUES, GOODWILL OR INDIRECT, SPECIAL, INCIDENTAL, CONSEQUENTIAL, EXEMPLARY, COVER, BUSINESS INTERRUPTION OR PUNITIVE DAMAGES, WHETHER AN ACTION IS IN CONTRACT OR TORT AND REGARDLESS OF THE THEORY OF LIABILITY, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGES OR IF A REMEDY OTHERWISE FAILS OF ITS ESSENTIAL PURPOSE. THE FOREGOING DISCLAIMER WILL NOT APPLY TO THE EXTENT PROHIBITED BY LAW. SFDO DISCLAIMS ALL LIABILITY AND INDEMNIFICATION OBLIGATIONS FOR ANY HARM OR DAMAGES CAUSED BY ANY THIRD-PARTY HOSTING PROVIDERS.

StaticResourceSources/npsp-slds/npsp-common.css

@@ -17,6 +17,7 @@ input.lookupInput {
 input.lookupInputSLDS {
     width: 100%;
     margin-right: -30px !important;
+    border-color: #747474 !important;
 }
 body .dateInput input[type="text"], .slds-vf-scope .dateInput input[type="text"] {
     margin-left: 0;

cumulusci.yml

@@ -1,4 +1,4 @@
-minimum_cumulusci_version: 3.23.0
+minimum_cumulusci_version: 3.74.0
 project:
     name: Cumulus
     source_format: sfdx
@@ -221,13 +221,18 @@ tasks:
         options:
             update_future_releases: True
 
+    github_release:
+        options:
+            release_content: |
+                Check out the [Salesforce Release Notes](https://sfdc.co/bnL4Cb) or [Known Issues](https://issues.salesforce.com/) for details.
+
     github_release_notes:
         options:
             trial_info: "`TBD`"
 
     is_rd2_enabled:
         description: This preflight check ensures that Enhanced Recurring Donations is enabled
-        class_path: tasks.is_rd2_enabled
+        class_path: tasks.check_rd2_enablement.is_rd2_enabled
         group: NPSP
 
     robot:
@@ -769,6 +774,12 @@ tasks:
                 - "*.cls"
 
 flows:
+
+    release_production:
+        steps:
+            3:
+                task: None
+
     build_unlocked_test_package:
         steps:
             0:
@@ -1778,8 +1789,12 @@ orgs:
             namespaced: True
         trial:
             config_file: orgs/trial.json
-        enterprise:
+        metecho_trial:
             config_file: orgs/enterprise.json
+            days: 30
+            setup_flow: config_trial_org
+        enterprise:
+            config_file: orgs/dev.json
 
 plans:
     existing_org:

force-app/main/default/classes/ACCT_ViewOverride_CTRL.cls

@@ -47,7 +47,10 @@ public with sharing class  ACCT_ViewOverride_CTRL {
     public ACCT_ViewOverride_CTRL (ApexPages.StandardController controller)
     {
         //get the account with the npe01__one2oneContact__c field for use in the rederict if necessary
-        List <Account> accounts = [select id, npe01__one2oneContact__c, npe01__SYSTEM_AccountType__c from Account where id = :ApexPages.currentPage().getParameters().get('id')];
+        // WITH SECURITY_ENFORCED isn't really necessary, but it won't hurt anything and should pass automated
+        // security checks
+        List <Account> accounts = [select id, npe01__one2oneContact__c, npe01__SYSTEM_AccountType__c
+            from Account where id = :ApexPages.currentPage().getParameters().get('id') WITH SECURITY_ENFORCED];
         if (accounts.size() > 0)
         {
             account = accounts[0];

force-app/main/default/classes/ALLO_Allocations_TDTM.cls

@@ -226,14 +226,22 @@ public class ALLO_Allocations_TDTM extends TDTM_Runnable {
     private void runPaymentTriggerHandler(List<SObject> newlist, List<SObject> oldlist,
         TDTM_Runnable.Action triggerAction, Schema.DescribeSObjectResult objResult) {
 
+
+        //do not run if Payment allocations are disabled
+        if (isPaymentAllocationsEnabled()) {
+            processPaymentAllocations(newlist, oldlist, triggerAction);
+        }
+
+        if (triggerAction == TDTM_Runnable.Action.AfterInsert || triggerAction == TDTM_Runnable.Action.AfterUpdate) {
+            handleAllocationsAndOpportunities(newList, oldList);
+        }
+    }
+
+    private void processPaymentAllocations(List<SObject> newlist, List<SObject> oldlist, TDTM_Runnable.Action triggerAction) {
         List<npe01__OppPayment__c> listPmtsForProcessing = new List<npe01__OppPayment__c>();
         List<npe01__OppPayment__c> pmtsWithNullOldAmount = new List<npe01__OppPayment__c>();
         List<npe01__OppPayment__c> pmtsNeedingAllocations = new List<npe01__OppPayment__c>();
 
-        //do not run if Payment allocations are disabled
-        if (!isPaymentAllocationsEnabled()) {
-            return;
-        }
 
         for (integer i=0; i<newList.size(); i++) {
             npe01__OppPayment__c pmt = (npe01__OppPayment__c) newlist[i];
@@ -280,10 +288,49 @@ public class ALLO_Allocations_TDTM extends TDTM_Runnable {
             fillMapWrapper(pmts);
 
             paymentAmountCurrencyChange(pmts);
-            //paymentAmountCurrencyChange(listPmtsForProcessing);
         }
     }
 
+    private void handleAllocationsAndOpportunities(
+        List<npe01__OppPayment__c> newList,
+        List<npe01__OppPayment__c> oldList
+    ) {
+        List<npe01__OppPayment__c> refunds = new List<npe01__OppPayment__c>();
+        List<npe01__OppPayment__c> oldRefunds = new List<npe01__OppPayment__c>();
+        for (Integer i = 0; i < newList.size(); i++) {
+            if (newList[i].npe01__Payment_Amount__c < 0 && String.isBlank(newList[i].Elevate_Payment_ID__c) && hasRefundDebitType(newList[i])) {
+                refunds.add(newList[i]);
+                if ( oldList != null) {
+                    oldRefunds.add(oldList[i]);
+                }
+            }
+        }
+
+        if (refunds.isEmpty()) {
+            return;
+        }
+
+        PMT_RefundService refundService = new PMT_RefundService()
+            .withRefundRecords(refunds)
+            .withOldRefundRecords(oldRefunds);
+
+        refundService.adjustAllocationsAndOpportunities()
+            .updateAllocationsAndOpportunities();
+
+        List<ErrorRecord> errorRecords = refundService.getErrors();
+
+        for (ErrorRecord error : errorRecords) {
+            if (error.hasError()) {
+                error.getRecord().addError(error.getFirstError());
+            }
+        }
+    }
+
+    private Boolean hasRefundDebitType (npe01__OppPayment__c payment) {
+        return (payment.DebitType__c == PMT_RefundService.PARTIAL_REFUND 
+            || payment.DebitType__c == PMT_RefundService.FULL_REFUND);
+    }
+
     /*******************************************************************************************************
     * @description Allocations before trigger handler on GAU Allocation. Validates allocation data per
     * object and per parent object to avoid badly created allocations, exceeding opportunity amount,
@@ -799,9 +846,10 @@ public class ALLO_Allocations_TDTM extends TDTM_Runnable {
                         }
                     }
                     //if the Opportunity amount has decreased, we run the risk of allocations exceeding the total opportunity amount
-                    if (oppWrap.totalAmount > oppWrap.parentAmount)
+                    if (oppWrap.totalAmount > oppWrap.parentAmount) {
                         //using addError here because we want to block opportunity update, display the error inline, and block the DML of updating all the related allocations
                         opp.Amount.addError(Label.alloExceedsOppAmount);
+                    }
                 }
             //if we have no allocations for this opportunity, defaults are enabled, and the opportunity has an amount, make a default allocation
             } else if (settings.Default_Allocations_Enabled__c && opp.Amount != null) {

force-app/main/default/classes/ALLO_Allocations_TEST.cls

@@ -433,6 +433,104 @@ private with sharing class ALLO_Allocations_TEST {
 
     }
 
+    /*******************************************************************************************************
+    * @description When working with negative and positive Payments:
+    * A mixture of positive and negative payments should be successfully inserted
+    * This test was created to ensure we are not breaking Accounting Subledger functionality
+    ********************************************************************************************************/
+    static testMethod void pmtsWithPositiveAndNegativeAmounts() {
+        Date todaysDate = System.today();
+        Date tomorrowsDate = System.today().addDays(1);
+        Date todayPlusOneMonthsDate = System.today().addMonths(1);
+        Date todayPlusTwoMonthsDate = System.today().addMonths(2);
+        Date todayPlusThreeMonthsDate = System.today().addMonths(3);
+
+        General_Accounting_Unit__c defaultGau = new General_Accounting_Unit__c(Name='default GAU');
+        insert defaultGau;
+
+        setupSettings(new Allocations_Settings__c(
+            Payment_Allocations_Enabled__c = true,
+            Default_Allocations_Enabled__c = true,
+            Default__c = defaultGau.Id));
+
+        Account acc = new Account(Name='Account-pmtAmountChange');
+        insert acc;
+
+        List<General_Accounting_Unit__c> gaus = UTIL_UnitTestData_TEST.createGAUs(4);
+        insert gaus;
+
+        Opportunity opp = new Opportunity(Name='Opp-pmtAmountChange', Amount = 1000, AccountID=acc.Id, CloseDate=System.today(), StageName=UTIL_UnitTestData_TEST.getOpenStage(), npe01__Do_Not_Automatically_Create_Payment__c=true);
+        insert opp;
+
+        //Create Opportunity Allocation Defaults
+        List<Allocation__c> oppAllocations = new List<Allocation__c>();
+        Allocation__c opp1Allo1 = new Allocation__c(General_Accounting_Unit__c = gaus[0].Id,
+                Amount__c = 200, //20%
+                Opportunity__c = opp.Id);
+                Allocation__c opp1Allo2 = new Allocation__c(General_Accounting_Unit__c = gaus[1].Id,
+                Amount__c = 800, //80%
+                Opportunity__c = opp.Id);
+
+        oppAllocations.add(opp1Allo1);
+        oppAllocations.add(opp1Allo2);
+
+        insert oppAllocations;
+
+        List<npe01__OppPayment__c> payments = new List<npe01__OppPayment__c>();
+        npe01__OppPayment__c p1 = new npe01__OppPayment__c(npe01__Opportunity__c = opp.Id,
+            npe01__Scheduled_Date__c = todaysDate, npe01__Payment_Amount__c = 400);
+        npe01__OppPayment__c p2 = new npe01__OppPayment__c(npe01__Opportunity__c = opp.Id,
+            npe01__Scheduled_Date__c = todayPlusOneMonthsDate, 
+            npe01__Payment_Amount__c = 600);
+        payments.add(p1);
+        payments.add(p2);
+
+        insert payments;
+
+        opp.StageName = UTIL_UnitTestData_TEST.getClosedWonStage();
+        update opp;
+
+        payments = new List<npe01__OppPayment__c>();
+
+        //Now Insert a mixture of payments
+        p1 = new npe01__OppPayment__c(
+                npe01__Opportunity__c = opp.Id,
+                npe01__Payment_Date__c = todaysDate,
+                npe01__Paid__c = true,
+                npe01__Payment_Amount__c = 300);
+        p2 = new npe01__OppPayment__c(
+                npe01__Opportunity__c = opp.Id,
+                npe01__Payment_Date__c = todayPlusOneMonthsDate,
+                npe01__Paid__c = true,
+                npe01__Payment_Amount__c = -200);
+        npe01__OppPayment__c p3 = new npe01__OppPayment__c(
+                npe01__Opportunity__c = opp.Id,
+                npe01__Payment_Date__c = todayPlusTwoMonthsDate,
+                npe01__Paid__c = true,
+                npe01__Payment_Amount__c = 500);
+        npe01__OppPayment__c p4 = new npe01__OppPayment__c(
+                npe01__Opportunity__c = opp.Id,
+                npe01__Payment_Date__c = todayPlusThreeMonthsDate,
+                npe01__Paid__c = true,
+                npe01__Payment_Amount__c = -600);
+
+        payments.add(p1);
+        payments.add(p2);
+        payments.add(p3);
+        payments.add(p4);
+
+        Test.startTest();
+        insert payments;
+        Test.stopTest();
+
+        List<Allocation__c> queryAllo = getAllocationsOrderByPercent(p1.Id, gaus[0].Id);
+        System.assertEquals(300 * 0.2, queryAllo[0].Amount__c, 'The allocation amount should be 20% of the Payment');
+
+        queryAllo = getAllocationsOrderByPercent(p2.Id, gaus[0].Id);
+        System.assertEquals(-200 * 0.2, queryAllo[0].Amount__c, 'The allocation amount should be 20% of the Payment');
+
+    }
+
     /*******************************************************************************************************
     * @description When working with negative amount Payments:
     * Updating the amount will adjust the percentage allocations.