-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Feature/254 to Main #7267
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Code added in BDI_DataImportService.cls to ensure all relevant fields of contact are updated
test method 'testImportAccounts' added in BDI_DataImportService_TEST.cls
Added checks while setting default address in createAndUpdateHouseholdAddresses method
…98313-data-import-incorrectly-updates-contact W-14398313 data import incorrectly update contact fields
…t-default-address-to-seasonal
…39175-new-contact-changes-account-default-address-to-seasonal W-14539175 -Adding new contact changes default address on Account
…Api-Name Populate Batch Defaults field of DataImportBatch with keys as field labels instead of field names.
…55774-npsp-get-start-ui-kondo-update W-16555774 Get Started Kondo UI Update
Set the batch-defaults field values to `undefined` to prevent null and blank values in form elements after updating batch-defaults.
* Changes in Addresses.cls and ContactAdapter.cls Added changes in Addresses.cls and ContactAdapter.cls to fix Contact Address Override Functionality * Changes in ADDR_Addresses_TEST.cls Assertions added in 'updatedUndeliverableDefaultAddressDoesNotCauseMultipleOverrideUpdates' method * Removed the check that was used to clear the override flag. * Rearrange conditional check in Addresses.cls * Changes in ContactAdapter.cls to avoid null pointer exception * Revert "Changes in ContactAdapter.cls to avoid null pointer exception" This reverts commit c45698c. * Changes in ADDR_Addresses_TEST.cls Changes added in 'updatedUndeliverableAddressShouldSyncToAccountAndHouseholdContactOverrides' test method * Changes in 'createAddressFromContactAndSetCurrentAddressLookupId' method of ContactAdapter.cls * changes for test methods in ACCT_AccountMerge_TEST and ADDR_Contacts_TEST
…ation-fields-in-gift-entry
…08598-set-defaults-for-GAU-Allocation-fields-in-gift-entry W-14308598 set batch default Values for GAU Allocation fields
To handle the error, added 'executeDMLInChunks' method in PSC_ManageSoftCredits_CTRL.cls
This reverts commit aa7c859.
Setting the form-state field values to null for all fields that are undefined when updating or selecting another contact prior to upserting the data import record.
…ageSoftCredits_TEST class
…iles Adding files from OSS template
…33417-DI-field-values-not-update-with-null-values W-15233417 - Gift Entry does not update to override null DI field values
… Gift Entry Added a check to skip clearing the Donation Amount when a DI Batch is not processed through Gift Entry.
…a Gift Entry Batch
…48425-Donation-Amount-gets-cleared-out-on-DI-record W-17048425 - Donation Amount field on DI record gets cleared out after Batch processing
…53462-soft-credit-chunking-error W-15353462 - fix chunking error on Manage Soft Credits
…38518-fix-Math-Exception-on-Duplicate-Contact-Merge W-15738518 - fix Math Exception on Duplicate Contact Merge
daniel-fuller
requested review from
force2b,
andrewyu-salesforce and
lparrott
November 21, 2024 19:22
@daniel-fuller There's one failing unit test on this |
@force2b posted in slack to address. https://salesforce-internal.slack.com/archives/C024DTWG3DX/p1732223803996809 |
lparrott
approved these changes
Nov 25, 2024
andrewyu-salesforce
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Critical Changes
Changes
Issues Closed
Community Ideas Delivered
Features Intended for Future Release
Features for Elevate Customers
New Metadata
Deleted Metadata
Unaggregated Pull Requests