Fix products list sorting (#255)

SallaApp · Sep 27, 2023 · 15938b5 · 15938b5
1 parent 349baa3
commit 15938b5
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 16 deletions.
diff --git a/public/app.js b/public/app.js
diff --git a/public/home.js b/public/home.js
diff --git a/public/landing.js b/public/landing.js
diff --git a/public/product.js b/public/product.js
diff --git a/public/product.js.LICENSE.txt b/public/product.js.LICENSE.txt
@@ -0,0 +1 @@
+/*! regenerator-runtime -- Copyright (c) 2014-present, Facebook, Inc. -- license (MIT): https://github.com/facebook/regenerator/blob/main/LICENSE */
diff --git a/src/assets/js/app.js b/src/assets/js/app.js
@@ -20,7 +20,6 @@ class App extends AppHelpers {
     this.initiateDropdowns();
     this.initiateModals();
     this.initiateCollapse();
-    this.reloadPageAfterFiltering();
     initTootTip();
     this.loadModalImgOnclick();
 
@@ -31,13 +30,6 @@ class App extends AppHelpers {
     this.log('Theme Loaded 🎉');
   }
 
-  // reload page after filtering 
-  reloadPageAfterFiltering(){
-    document.querySelector('#product-filter')?.addEventListener('change',()=>{
-      location.reload();
-    })
-  }
-
   log(message) {
     salla.log(`ThemeApp(Raed)::${message}`);
     return this;

diff --git a/src/assets/js/products.js b/src/assets/js/products.js
@@ -13,11 +13,11 @@ class Products extends BasePage {
 
 
         // Sort Products
-        app.on('change', '#product-filter', event => {
-            let url = new URL(window.location.href);
-            url.searchParams.set('sort', event.currentTarget.value);
-            window.history.pushState({}, '', url);
+        app.on('change', '#product-filter', async event => {
+            window.history.replaceState(null, null, salla.helpers.addParamToUrl('sort', event.currentTarget.value));
             productsList.sortBy = event.currentTarget.value;
+            await productsList.reload();
+            productsList.setAttribute('filters', `{"sort": "${event.currentTarget.value}"}`)
         });
 
         salla.event.once('salla-products-list::products.fetched', res=>{
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		/! regenerator-runtime -- Copyright (c) 2014-present, Facebook, Inc. -- license (MIT): https://github.com/facebook/regenerator/blob/main/LICENSE /