Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatAutocomplete new component #550

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

sandrohanea
Copy link
Contributor

This new component is based on MatInputTextComponent so all properties from the text input will be on this and usable(e.g. Disabled, etc).

I thought to keep the SelectedItem from MatAutocompleteList as I saw a lot of people are using it(previously named Value). Now Value will be the text and SelectedItem the item in the list which was selected either with the mouse or with the keyboard( Arrows + Enter).

I added IAutocompleteItemsSource to offer the possibility to use this component with a backend filtering instead of filtering on the UI in the component.

@Gareth064
Copy link

Hi @sandrohanea I am liking the look of this new AutoComplete :) is there an eta on it?

@sandrohanea
Copy link
Contributor Author

Hi @sandrohanea I am liking the look of this new AutoComplete :) is there an eta on it?

Hi @Gareth064
I don't have an ETA on it but I'll try to work on it this weekend to close more issues for it( MatAutocomplete in Dialog, etc). If everything will go as I planned I can provide a PR this week or later next week but I cannot promise it.

@Gareth064
Copy link

Gareth064 commented Jun 5, 2020

Hi @sandrohanea I am liking the look of this new AutoComplete :) is there an eta on it?

Hi @Gareth064
I don't have an ETA on it but I'll try to work on it this weekend to close more issues for it( MatAutocomplete in Dialog, etc). If everything will go as I planned I can provide a PR this week or later next week but I cannot promise it.

That's great dude :) There is 1.5 bugs in MatAutoCompleteList which I was wondering if you could comment on in regards of how the behaviour is handled in this new version. They are #577 and #592

Also I had mentioned about enabling a Vertical scroll on the list via #587. What do you think about that?

I have an app that is fully MatBlazor with the exception of the Auto Complete list component because of those first 2 bug. So I am looking forward to this new one so I can update my app so everything looks great 👍

@sandrohanea sandrohanea marked this pull request as ready for review July 6, 2020 13:05
@sandrohanea
Copy link
Contributor Author

sandrohanea commented Jul 6, 2020

I couldn't manage to finish it but I got help from @dbereghici so it's ready for review now.

Thanks again @dbereghici !

@sandrohanea sandrohanea changed the title MatAutocomplete new component WIP MatAutocomplete new component Jul 6, 2020
@Christian-Oleson
Copy link
Contributor

@Gareth064 ,
There are now some conflictss here.

@TimPosey2
Copy link

Any chance this will be merged anytime soon?

@CSOleson
Copy link
Contributor

Any chance this will be merged anytime soon?

I see conflicts, so I doubt it.

@sandrohanea
Copy link
Contributor Author

I fixed the conflicts.

@TimPosey2
Copy link

Many thanks, @sandrohanea. I'll help with documentation and some samples once this is merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants