Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Role extend CustomBaseModel and add content_type field #1392

Merged
merged 6 commits into from
Sep 24, 2024

Conversation

robines
Copy link
Member

@robines robines commented Sep 24, 2024

The content_type informs the user which hierarchy the role is meant for (Org/Gang/Section). This makes filtering based on hierarchy possible. The content_type field may be blank, if creating a role which can be used on either hierarchy.

@robines robines self-assigned this Sep 24, 2024
@robines robines added the backend Task related to backend. label Sep 24, 2024
Copy link
Contributor

@Mathias-a Mathias-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ig 🤷

Copy link
Contributor

@emsoraffa emsoraffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :wq

@robines robines merged commit 6278a9c into master Sep 24, 2024
5 checks passed
@robines robines deleted the robin/update-role-model branch September 24, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Task related to backend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants