1535 bug withdrawn application showing up for applicant

backend/samfundet/migrations/0011_alter_recruitmentapplication_applicant_priority_and_more.py

@@ -0,0 +1,60 @@
+# Generated by Django 5.1.1 on 2024-11-03 01:16
+
+import django.db.models.deletion
+from django.conf import settings
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('samfundet', '0010_recruitment_promo_media'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='recruitmentapplication',
+            name='applicant_priority',
+            field=models.PositiveIntegerField(blank=True, help_text='Applicant priority of the position(recruitment_position) to which this application related.', null=True),
+        ),
+        migrations.AlterField(
+            model_name='recruitmentapplication',
+            name='applicant_state',
+            field=models.IntegerField(choices=[(0, 'Unprocessed by all above on priority'), (1, 'Highest priority, and reserve'), (2, 'Highest priority, and wanted'), (3, 'Another position has this on reserve, with higher priority'), (4, 'Another position has this on reserve, with higher priority, but you have reserved'), (5, 'Another position has this on reserve, with higher priority, but you have them as wanted'), (6, 'Another position has this on reserve, with higher priority'), (7, 'Another position has this on wanted, with higher priority, but you have reserved'), (8, 'Another position has this on wanted, with higher priority, but you have them as wanted'), (10, 'Other position has priority')], default=0, help_text="Recruiter's view of the applicant's status."),
+        ),
+        migrations.AlterField(
+            model_name='recruitmentapplication',
+            name='application_text',
+            field=models.TextField(help_text='Motivation text submitted by the applicant'),
+        ),
+        migrations.AlterField(
+            model_name='recruitmentapplication',
+            name='interview',
+            field=models.ForeignKey(blank=True, help_text='Interview associated with this application.', null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='applications', to='samfundet.interview'),
+        ),
+        migrations.AlterField(
+            model_name='recruitmentapplication',
+            name='recruiter_priority',
+            field=models.IntegerField(choices=[(0, 'Not Set'), (1, 'Reserve'), (2, 'Wanted'), (3, 'Not Wanted')], default=0, help_text="Recruiter's priority for this application - should not be visible to applicant"),
+        ),
+        migrations.AlterField(
+            model_name='recruitmentapplication',
+            name='recruiter_status',
+            field=models.IntegerField(choices=[(0, 'Not Set'), (1, 'Called and Accepted'), (2, 'Called and Rejected'), (3, 'Rejection'), (4, 'Automatic Rejection')], default=0, help_text='Current status of this application.'),
+        ),
+        migrations.AlterField(
+            model_name='recruitmentapplication',
+            name='recruitment',
+            field=models.ForeignKey(help_text='Recruitment to which this application is related.', on_delete=django.db.models.deletion.CASCADE, related_name='applications', to='samfundet.recruitment'),
+        ),
+        migrations.AlterField(
+            model_name='recruitmentapplication',
+            name='recruitment_position',
+            field=models.ForeignKey(help_text='Position to which this application is related.', on_delete=django.db.models.deletion.CASCADE, related_name='applications', to='samfundet.recruitmentposition'),
+        ),
+        migrations.AlterField(
+            model_name='recruitmentapplication',
+            name='user',
+            field=models.ForeignKey(help_text='User who submitted this application.', on_delete=django.db.models.deletion.CASCADE, related_name='applications', to=settings.AUTH_USER_MODEL),
+        ),
+    ]

backend/samfundet/models/tests/test_recruitment.py

@@ -836,6 +836,134 @@ def test_recruitment_progress_applications_multiple_new_updates_progress(
         assert fixture_recruitment.recruitment_progress() == 1
 
 
+@pytest.mark.django_db
+def test_withdrawn_application_priority_handling(
+    fixture_recruitment_application: RecruitmentApplication,
+    fixture_recruitment_application2: RecruitmentApplication,
+    fixture_recruitment_position2: RecruitmentPosition,
+):
+    """Test that priorities are properly managed when applications are withdrawn"""
+    # Initial state - two applications with priorities 1 and 2
+    assert fixture_recruitment_application.applicant_priority == 1
+    assert fixture_recruitment_application2.applicant_priority == 2
+
+    # When withdrawing application 1, application 2 should become priority 1
+    fixture_recruitment_application.withdrawn = True
+    fixture_recruitment_application.save()
+
+    fixture_recruitment_application.refresh_from_db()
+    fixture_recruitment_application2.refresh_from_db()
+
+    assert fixture_recruitment_application.applicant_priority is None
+    assert fixture_recruitment_application2.applicant_priority == 1
+
+    # New application should get priority 2
+    new_application = RecruitmentApplication.objects.create(
+        application_text='Test application text 3',
+        recruitment_position=fixture_recruitment_position2,
+        recruitment=fixture_recruitment_position2.recruitment,
+        user=fixture_recruitment_application.user,
+    )
+
+    assert new_application.applicant_priority == 2
+
+
+@pytest.mark.django_db
+def test_reapplying_after_withdrawal_priority(
+    fixture_recruitment_application: RecruitmentApplication, fixture_recruitment_application2: RecruitmentApplication
+):
+    """Test that reapplying after withdrawal gets correct priority"""
+    # Initial state
+    assert fixture_recruitment_application.applicant_priority == 1
+    assert fixture_recruitment_application2.applicant_priority == 2
+
+    # Withdraw first application
+    fixture_recruitment_application.withdrawn = True
+    fixture_recruitment_application.save()
+
+    fixture_recruitment_application2.refresh_from_db()
+    assert fixture_recruitment_application2.applicant_priority == 1
+
+    # Reapply - should get priority 2
+    fixture_recruitment_application.withdrawn = False
+    fixture_recruitment_application.save()
+
+    fixture_recruitment_application.refresh_from_db()
+    fixture_recruitment_application2.refresh_from_db()
+
+    assert fixture_recruitment_application2.applicant_priority == 1
+    assert fixture_recruitment_application.applicant_priority == 2
+
+
+@pytest.mark.django_db
+def test_priority_constraints_with_withdrawn_applications(
+    fixture_recruitment_application: RecruitmentApplication,
+    fixture_recruitment_application2: RecruitmentApplication,
+    fixture_recruitment_position2: RecruitmentPosition,
+):
+    """Test that priorities stay within bounds of active applications only"""
+    # Initial state
+    assert fixture_recruitment_application.applicant_priority == 1
+    assert fixture_recruitment_application2.applicant_priority == 2
+
+    # Withdraw application 2
+    fixture_recruitment_application2.withdrawn = True
+    fixture_recruitment_application2.save()
+
+    fixture_recruitment_application.refresh_from_db()
+    assert fixture_recruitment_application.applicant_priority == 1
+
+    # Try to set priority higher than number of active applications
+    with pytest.raises(ValidationError):
+        fixture_recruitment_application.applicant_priority = 2
+        fixture_recruitment_application.save()
+
+
+@pytest.mark.django_db
+def test_multiple_withdrawals_and_priorities(
+    fixture_recruitment: Recruitment, fixture_recruitment_position: RecruitmentPosition, fixture_recruitment_position2: RecruitmentPosition, fixture_user: User
+):
+    """Test complex scenario with multiple withdrawals and reapplications"""
+    # Create three applications
+    apps = []
+    for i in range(3):
+        app = RecruitmentApplication.objects.create(
+            application_text=f'Test application {i}',
+            recruitment_position=fixture_recruitment_position if i < 2 else fixture_recruitment_position2,
+            recruitment=fixture_recruitment,
+            user=fixture_user,
+        )
+        apps.append(app)
+
+    # Verify initial priorities
+    for i, app in enumerate(apps, 1):
+        assert app.applicant_priority == i
+
+    # Withdraw middle application
+    apps[1].withdrawn = True
+    apps[1].save()
+
+    # Refresh and verify priorities adjusted
+    for app in apps:
+        app.refresh_from_db()
+
+    assert apps[0].applicant_priority == 1
+    assert apps[1].applicant_priority is None
+    assert apps[2].applicant_priority == 2
+
+    # Withdraw first application
+    apps[0].withdrawn = True
+    apps[0].save()
+
+    # Refresh and verify
+    for app in apps:
+        app.refresh_from_db()
+
+    assert apps[0].applicant_priority is None
+    assert apps[1].applicant_priority is None
+    assert apps[2].applicant_priority == 1
+
+
 def test_position_must_have_single_owner(fixture_recruitment_position: RecruitmentPosition, fixture_gang: Gang, fixture_gang_section: GangSection):
     fixture_recruitment_position.gang = fixture_gang
     fixture_recruitment_position.section = fixture_gang_section