Recruitmentvalidation and Form Errors #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magsyg
requested review from
emilte,
evgiz,
Mathias-a and
robines
as code owners
magsyg
force-pushed
the
feature/recruitmentvalidation
branch
from
c8bd161
to
1fd30a0
Compare
magsyg
force-pushed
the
feature/recruitmentvalidation
branch
from
1fd30a0
to
cff4bd5
Compare
emilte
reviewed
Dec 22, 2023
emilte
reviewed
Dec 22, 2023
emilte
reviewed
Dec 22, 2023
emilte
reviewed
Dec 22, 2023
Snorre98
previously approved these changes
Jan 5, 2024
|
@emilte dis gud? |
magsyg
force-pushed
the
feature/recruitmentvalidation
branch
from
e95dd91
to
5dcd659
Compare
added 2 commits
January 6, 2024 21:43
emilte
reviewed
Jan 7, 2024
magsyg
force-pushed
the
feature/recruitmentvalidation
branch
from
8743fd6
to
f70bc59
Compare
emilte
reviewed
Feb 15, 2024
emilte
reviewed
Feb 15, 2024
frontend/src/PagesAdmin/RecruitmentFormAdminPage/RecruitmentFormAdminPage.tsx
Outdated
Show resolved
Hide resolved
snorrekr
approved these changes
Feb 15, 2024
Snorre98
approved these changes
Feb 15, 2024
robines
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
La til validerings metode som kanskje kan standardiseres gjennom resten av serializerne, returnererer field errors som json istedenfor å krasje fra clean metoden til et object
Samtidig la til muligheten til å vise errors from backend i frontend
For er jævlig piss å ikke få bekreftelse av feilene, og kun en error melding