Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java format checker to github Actions #262

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Add java format checker to github Actions #262

merged 1 commit into from
Oct 26, 2023

Conversation

tdrozdovsky
Copy link
Collaborator

Description

You need to add a checker to match the style code

Type of change

  • Code cleanup/refactoring

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Below is just an example and you can delete it when you contribute.

See github->actions

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions
Copy link

<title>lpvs</title><script type="text/javascript" src="jacoco-resources/sort.js"></script>

lpvs

ElementMissed InstructionsCov.Missed BranchesCov.MissedCxtyMissedLinesMissedMethodsMissedClasses
Total1,437 of 6,68278%196 of 51662%1926672881,33149409757
com.lpvs.service6481,63271%9314160%6717113751375408
com.lpvs.entity.auth22825652%50%123055112112925
com.lpvs.service.scanner.scanoss16936568%272750%2736361145946
com.lpvs.entity.dashboard13213650%31922%254221852203
com.lpvs.util10661285%166279%21672815362815
com.lpvs.entity8997391%173164%292091416413185012
com.lpvs.controller3861994%93177%836512601603
com.lpvs271941%20%3511182401
com.lpvs.entity.enums326100%18100%02305301404
com.lpvs.entity.result117100%n/a02102102103
com.lpvs.exception109100%n/a01202401204
com.lpvs.entity.history81100%n/a01501501503
Created with JaCoCo 0.8.8.202204050719

Copy link
Member

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using AOSP style (4-space indentation)?

@tiokim tiokim marked this pull request as draft October 25, 2023 07:00
@github-actions
Copy link

<title>lpvs</title><script type="text/javascript" src="jacoco-resources/sort.js"></script>

lpvs

ElementMissed InstructionsCov.Missed BranchesCov.MissedCxtyMissedLinesMissedMethodsMissedClasses
Total1,437 of 6,68278%196 of 51662%1926672881,33149409757
com.lpvs.service6481,63271%9314160%6717113751375408
com.lpvs.entity.auth22825652%50%123055112112925
com.lpvs.service.scanner.scanoss16936568%272750%2736361145946
com.lpvs.entity.dashboard13213650%31922%254221852203
com.lpvs.util10661285%166279%21672815362815
com.lpvs.entity8997391%173164%292091416413185012
com.lpvs.controller3861994%93177%836512601603
com.lpvs271941%20%3511182401
com.lpvs.entity.enums326100%18100%02305301404
com.lpvs.entity.result117100%n/a02102102103
com.lpvs.exception109100%n/a01202401204
com.lpvs.entity.history81100%n/a01501501503
Created with JaCoCo 0.8.8.202204050719

@github-actions
Copy link

<title>lpvs</title><script type="text/javascript" src="jacoco-resources/sort.js"></script>

lpvs

ElementMissed InstructionsCov.Missed BranchesCov.MissedCxtyMissedLinesMissedMethodsMissedClasses
Total1,361 of 6,67979%196 of 51662%1886672721,33045409757
com.lpvs.service6671,74972%9414260%7017813854296009
com.lpvs.service.scanner.scanoss16936568%272750%2736361145946
com.lpvs.config1330%n/a5538385522
com.lpvs.entity.dashboard13213650%31922%254221852203
com.lpvs.util10661285%166279%21672815362815
com.lpvs.entity8997391%173164%292091416413185012
com.lpvs.controller3861994%93177%836512601603
com.lpvs2741%20%3511182401
com.lpvs.entity.enums495100%18100%03108602205
com.lpvs.entity.result117100%n/a02102102103
com.lpvs.exception109100%n/a01202401204
com.lpvs.entity.history81100%n/a01501501503
com.lpvs.entity.auth43100%n/a01001101001
Created with JaCoCo 0.8.8.202204050719

@github-actions
Copy link

<title>lpvs</title><script type="text/javascript" src="jacoco-resources/sort.js"></script>

lpvs

ElementMissed InstructionsCov.Missed BranchesCov.MissedCxtyMissedLinesMissedMethodsMissedClasses
Total1,361 of 6,67979%196 of 51662%1886672721,33045409757
com.lpvs.service6671,74972%9414260%7017813854296009
com.lpvs.service.scanner.scanoss16936568%272750%2736361145946
com.lpvs.config1330%n/a5538385522
com.lpvs.entity.dashboard13213650%31922%254221852203
com.lpvs.util10661285%166279%21672815362815
com.lpvs.entity8997391%173164%292091416413185012
com.lpvs.controller3861994%93177%836512601603
com.lpvs2741%20%3511182401
com.lpvs.entity.enums495100%18100%03108602205
com.lpvs.entity.result117100%n/a02102102103
com.lpvs.exception109100%n/a01202401204
com.lpvs.entity.history81100%n/a01501501503
com.lpvs.entity.auth43100%n/a01001101001
Created with JaCoCo 0.8.8.202204050719

@github-actions
Copy link

<title>lpvs</title><script type="text/javascript" src="jacoco-resources/sort.js"></script>

lpvs

ElementMissed InstructionsCov.Missed BranchesCov.MissedCxtyMissedLinesMissedMethodsMissedClasses
Total1,361 of 6,67979%196 of 51662%1886672721,33045409757
com.lpvs.service6671,74972%9414260%7017813854296009
com.lpvs.service.scanner.scanoss16936568%272750%2736361145946
com.lpvs.config1330%n/a5538385522
com.lpvs.entity.dashboard13213650%31922%254221852203
com.lpvs.util10661285%166279%21672815362815
com.lpvs.entity8997391%173164%292091416413185012
com.lpvs.controller3861994%93177%836512601603
com.lpvs2741%20%3511182401
com.lpvs.entity.enums495100%18100%03108602205
com.lpvs.entity.result117100%n/a02102102103
com.lpvs.exception109100%n/a01202401204
com.lpvs.entity.history81100%n/a01501501503
com.lpvs.entity.auth43100%n/a01001101001
Created with JaCoCo 0.8.8.202204050719

@github-actions
Copy link

<title>lpvs</title><script type="text/javascript" src="jacoco-resources/sort.js"></script>

lpvs

ElementMissed InstructionsCov.Missed BranchesCov.MissedCxtyMissedLinesMissedMethodsMissedClasses
Total1,361 of 6,67979%196 of 51662%1886672721,33045409757
com.lpvs.service6671,74972%9414260%7017813854296009
com.lpvs.service.scanner.scanoss16936568%272750%2736361145946
com.lpvs.config1330%n/a5538385522
com.lpvs.entity.dashboard13213650%31922%254221852203
com.lpvs.util10661285%166279%21672815362815
com.lpvs.entity8997391%173164%292091416413185012
com.lpvs.controller3861994%93177%836512601603
com.lpvs2741%20%3511182401
com.lpvs.entity.enums495100%18100%03108602205
com.lpvs.entity.result117100%n/a02102102103
com.lpvs.exception109100%n/a01202401204
com.lpvs.entity.history81100%n/a01501501503
com.lpvs.entity.auth43100%n/a01001101001
Created with JaCoCo 0.8.8.202204050719

Signed-off-by: Taras Drozdovskyi <[email protected]>
@github-actions
Copy link

<title>lpvs</title><script type="text/javascript" src="jacoco-resources/sort.js"></script>

lpvs

ElementMissed InstructionsCov.Missed BranchesCov.MissedCxtyMissedLinesMissedMethodsMissedClasses
Total1,361 of 6,67979%196 of 51662%1886672721,33045409757
com.lpvs.service6671,74972%9414260%7017813854296009
com.lpvs.service.scanner.scanoss16936568%272750%2736361145946
com.lpvs.config1330%n/a5538385522
com.lpvs.entity.dashboard13213650%31922%254221852203
com.lpvs.util10661285%166279%21672815362815
com.lpvs.entity8997391%173164%292091416413185012
com.lpvs.controller3861994%93177%836512601603
com.lpvs2741%20%3511182401
com.lpvs.entity.enums495100%18100%03108602205
com.lpvs.entity.result117100%n/a02102102103
com.lpvs.exception109100%n/a01202401204
com.lpvs.entity.history81100%n/a01501501503
com.lpvs.entity.auth43100%n/a01001101001
Created with JaCoCo 0.8.8.202204050719

@tdrozdovsky
Copy link
Collaborator Author

What about using AOSP style (4-space indentation)?

Done!

@tdrozdovsky tdrozdovsky marked this pull request as ready for review October 25, 2023 09:06
@tdrozdovsky tdrozdovsky changed the title [WIP] Add java format checker Add java format checker to github Actions Oct 25, 2023
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov
Copy link
Collaborator

Code style changes will be applied after merging all opened PRs.

@o-kopysov o-kopysov added the enhancement New feature or request label Oct 26, 2023
Copy link
Member

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit 748219c into main Oct 26, 2023
7 of 9 checks passed
@o-kopysov o-kopysov deleted the format-checker branch October 26, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants