Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply security best practices into workflows and Docker file #270

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

tdrozdovsky
Copy link
Collaborator

Description

Apply security best practices into workflows and Docker file. These changes are recommend by StepSecurity

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions
Copy link

<title>lpvs</title><script type="text/javascript" src="jacoco-resources/sort.js"></script>

lpvs

ElementMissed InstructionsCov.Missed BranchesCov.MissedCxtyMissedLinesMissedMethodsMissedClasses
Total922 of 6,67986%172 of 51666%1736671981,51939409557
com.lpvs.service3422,07485%7116569%601788761876009
com.lpvs.service.scanner.scanoss15438071%262851%2636351285946
com.lpvs.entity.dashboard13213650%31922%254221852203
com.lpvs.util10661285%166279%21672819862815
com.lpvs.entity8997391%173164%292091918213185012
com.lpvs.controller3861994%93177%836514701603
com.lpvs.config349974%n/a1510451502
com.lpvs2741%20%3512192401
com.lpvs.entity.enums495100%18100%03109202205
com.lpvs.entity.result117100%n/a02102102103
com.lpvs.exception109100%n/a01202901204
com.lpvs.entity.history81100%n/a01501501503
com.lpvs.entity.auth43100%n/a0100701001
Created with JaCoCo 0.8.8.202204050719

Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@o-konoval o-konoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, approved

@o-kopysov o-kopysov merged commit b19fe7b into main Oct 27, 2023
9 checks passed
@o-kopysov o-kopysov deleted the udate-security-workflows branch October 27, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants