[Do not merge] os/pm: restructure pm for LCD changes #6560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewoodev
reviewed
Dec 10, 2024
gSahitya-samsung
force-pushed
the
pm_design
branch
from
0bc3293 to
d2afca8
Compare
ewoodev
reviewed
Dec 16, 2024
| * | ||
| **************************************************************************/ | ||
|
|
||
| int (*prepare)(FAR struct pm_callback_s *cb, enum pm_state_e pmstate); | ||
| int (*sleep)(FAR struct pm_callback_s *cb); |
There was a problem hiding this comment.
prepare is not needed in new design because we have wake callback now. If before sleep, a driver failed to change its state according to the new PM state, it will raise ERROR then PM will wake all the slept driver immediately. The drivers must support wake operation. The prepare is only needed if we want to separate prepare functionality from sleep callback. Considering current NDP and Audio driver code this separation is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.