framework/Media: Add reset API for recorder and player. #6569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taejun-Kwon
previously approved these changes
Dec 10, 2024
aadotverma
reviewed
Dec 11, 2024
| * @details @b #include <media/MediaPlayer.h> | ||
| * This function is a synchronous API | ||
| * @return The result of the reset operation | ||
| * @since TizenRT v2.0 |
There was a problem hiding this comment.
Is this correct?
TizenRT v2.0
vibhor-m
force-pushed
the
pr_reset_recorder_player
branch
2 times, most recently
from
0738a3c to
05705c5
Compare
Taejun-Kwon
reviewed
Dec 17, 2024
| mInputHandler.close(); | ||
| if (reset_audio_stream_out(mStreamInfo->id) != AUDIO_MANAGER_SUCCESS) { | ||
| meddbg("MediaPlayer reset fail : reset_audio_stream_out fail\n"); | ||
| return PLAYER_ERROR_INTERNAL_OPERATION_FAILED; |
There was a problem hiding this comment.
In my opinion, if another thread already use audio manager, it should keep going on release resource in media.
so I think some warning message is enough, we should not return error.
There was a problem hiding this comment.
Thanks.
Changes Done as requested.
This commit add reset API for recorder and player which will help application to do reset for recorder and player to IDLE state.
s1-vivek
force-pushed
the
pr_reset_recorder_player
branch
from
05705c5 to
0523ad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit add reset API for recorder and player which will help application to do reset for recorder and player to IDLE state.