Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

framework/media, apps/examples: sync from ecode #6590

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kdotsaikrishna
Copy link
Contributor

sync media, focusmanager and example apps from Media

printf("prepare failed res : %d\n", res);
return res;
}
if (mLooping) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is looping to be done before prepare

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This change is already in a pr for ecode

@@ -49,7 +47,7 @@ using namespace media::voice;

media::voice::SpeechDetector *sd;

static const char *filePath = "/tmp/record.pcm";
static const char *filePath = "/mnt/record.pcm";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont change from /tmp

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change reverted.

Copy link

@dalvinder-s dalvinder-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Taejun-Kwon
Copy link
Contributor

src/media/stream_info.c: In function 'stream_info_create':
src/media/stream_info.c:33:23: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
(*stream_info)->id = (uint64_t)(*stream_info);

can you please verify above error in CircleCI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants