Prep for DriverKit #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move nvme_set_errno_from_cqe to header such that rq_test does not need to link with nvme/util.c. Signed-off-by: Klaus Jensen <[email protected]>
Add iommu/dmabuf.h which helps allocating and mapping DMA buffers. Signed-off-by: Klaus Jensen <[email protected]>
Replace all pgmap/iommu_map_vaddr pairs with iommu_get/put_dmabuf. Signed-off-by: Klaus Jensen <[email protected]>
birkelund
added
enhancement
The mmio helpers assume that we can read and write to a specific address. The proposed DriverKit backend cannot do that and must call specific functions on a base address and an offset. In the core, prepare for DriverKit to provide its own implementation of doing that. This is a simplified version of commit "mmio: convert calls of 'addr + offset' to 'base-addr, offset'" to limit the change to the nvme core. Signed-off-by: Mads Ynddal <[email protected]> [k.jensen: limit the change to nvme/core for now] Signed-off-by: Klaus Jensen <[email protected]>
Within DriverKit we cannot use malloc/free but have to use the DriverKit specific IOMallocZero and IOFree. Signed-off-by: Mads Ynddal <[email protected]> [k.jensen: allowed more generic functions to be retained] Signed-off-by: Klaus Jensen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks preparations for merging the DriverKit backend.
The first part of this is the new
iommu_dmabufAPI. This encapsulates memory allocation and mapping which should remove the need for the opaque pointer changes toiommu_map_vaddrand thepgmapAPIs. Instead, the DriverKit backend can implement its own version of the iommu_dmabuf API.The second part is to abstract register mmio. DriverKit cannot read/write to specific addresses and must call an API function that expects the base address and an offset. Abstract this in
nvme/corebut leave the public API otherwise unchanged for now.