Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synthesize ctor_move_dtor from ctor and move_dtor when necessary. #515

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Synthesize ctor_move_dtor from ctor and move_dtor when necessary. #515

wants to merge 2 commits into from
+28,052 −27,792

Conversation

jemc
Copy link

@jemc jemc commented Oct 26, 2021

When ctor_move_dtor is not set, but move and dtor are set,
but move_ctor is not set, then use move_dtor to synthesize it.

@jemc jemc force-pushed the lifecycle-improvements branch from 6fc6165 to d9907ac Compare October 29, 2021 14:16
jemc added 2 commits October 29, 2021 07:18
@jemc
Synthesize ctor_move_dtor from ctor and move_dtor when necessary.
e73abab 
When `ctor_move_dtor` is not set, but `move` and `dtor` are set,
but `move_ctor` is not set, then use `move_dtor` to synthesize it.
@jemc
Switch from using move to move_dtor in assign_ptr_w_id function.
4a887ed 
See this discord conversation for more background:
https://discord.com/channels/633826290415435777/633826290415435781/902342988158623744
@jemc jemc force-pushed the lifecycle-improvements branch from d9907ac to 4a887ed Compare October 29, 2021 14:18
@SanderMertens SanderMertens force-pushed the master branch 3 times, most recently from 8506832 to ef52875 Compare December 13, 2021 20:37
@SanderMertens SanderMertens force-pushed the master branch 3 times, most recently from a540dcc to 95a0110 Compare January 22, 2022 07:05
@SanderMertens SanderMertens force-pushed the master branch 2 times, most recently from 6485712 to 0326782 Compare March 7, 2022 09:48
@SanderMertens SanderMertens force-pushed the master branch 3 times, most recently from 07e1c0f to 5b6eef9 Compare May 31, 2022 18:00
@SanderMertens SanderMertens force-pushed the master branch 5 times, most recently from 3a11369 to e75f6f0 Compare August 22, 2022 08:19
@SanderMertens SanderMertens force-pushed the master branch 2 times, most recently from f277e75 to 61076ac Compare August 4, 2023 00:48
@SanderMertens SanderMertens force-pushed the master branch 2 times, most recently from 0b0631f to c4b01f9 Compare August 29, 2023 00:35
@SanderMertens SanderMertens force-pushed the master branch 3 times, most recently from 438bde4 to 220852f Compare December 13, 2023 23:59
@SanderMertens SanderMertens force-pushed the master branch 3 times, most recently from 3b99938 to ac6cdca Compare February 20, 2024 08:24
@SanderMertens SanderMertens force-pushed the master branch 8 times, most recently from ace232e to b968586 Compare March 13, 2024 18:12
@SanderMertens SanderMertens force-pushed the master branch 3 times, most recently from 301243a to 4a5784f Compare April 23, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jemc