Refactor as last post-processor #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other processors/extensions may generate headings, that might need to be downgraded. A prime example is the built-in raw HTML processing, that removes inline HTML processes the actual markdown, and then -- in a preprocessor -- puts the removed raw HTML back. To avoid this, the header downgrade logic has been moved to a postprocessor with a low priority (5) to make sure it's the last thing running.
Enable the user to add 'headdown="0"' to the tag, and make the extension skip this heading.
|
This will break on headings that have other attributes set. |
|
You are completely right; it's a good shout. Apparently I missed the last commit. ;) |
|
@SaschaCowley, please merge this pull request or specify the reasons for rejecting it when you have time. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #2.