Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braille formatting underline #24

Closed
wants to merge 779 commits into from
Closed

Conversation

SaschaCowley
Copy link
Owner

Link to issue number:

Summary of the issue:

Description of user facing changes

Description of development approach

Testing strategy:

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

NVDA translation automation and others added 30 commits May 24, 2024 00:03
From translation svn revision: 80755

Authors:
Zvonimir Stanecic <[email protected]>
Aleksandr Lin'kov <[email protected]>

Stats:
44	43	user_docs/ru/changes.md
211	211	user_docs/ru/userGuide.md
 2 files changed, 255 insertions(+), 254 deletions(-)
From translation svn revision: 80755

Authors:
Cagri Dogan <[email protected]>

Stats:
1	0	user_docs/tr/changes.md
70	35	user_docs/tr/userGuide.md
 2 files changed, 71 insertions(+), 35 deletions(-)
From translation svn revision: 80755
nvaccess#16553)

Summary of the issue:
Request from users for more initial documentation on getting around the Add-on store.
This PR adds a section to the Quick Start Guide (in the user guide) on the add-on store.

Description of user facing changes
New sub-topic in the Quick Start Guide section of the User Guide "Add-on Store" after existing section 2.4 Preferences and before 2.5 Community.
 nvda-l10n beta exchange
Various issues found in Sound Split feature description in the User Guide and in the GUI:

The User Guide does not explain the difference between "Sound split disabled" mode and "NVDA in both channels and applications in both channels" mode.
In the User Guide, the default option is called "Disabled sound split", but "Sound split disabled" in the GUI.
In the User Guide, the description of the way to restore the sound in both channels after a crash is not always correct, especially now that the "disabled" option does not modify audio processing at all.
The GUI warning when unchecking the Disabled mode is not correct since there are various other possible modes with speech in both channels (among them the new "NVDA both and app both"). The removal of this warning had been discussed and approved in Sound split nvaccess#16071 (comment) but never completed.
Description of user facing changes
User Guide updated for 3 first items.
Warning removed from the GUI
Following @seanbudd's suggestion in nvaccess#16591 making classes and functions private.
The rationale is that we would like to refactor sound split code so that more code is going to be reused in application volume adjuster, but nvaccess#16591 will have to be postponed to v2024.3. So we need to make sound split API private to avoid breaking API changes.
From translation svn revision: 80958

Authors:
Fatma Mehanna <[email protected]>
Shaimaa Ibrahim <[email protected]>
Abdelkrim Bensaid <[email protected]>
Omar Alojaimi <[email protected]>

Stats:
12	11	user_docs/ar/changes.md
 1 file changed, 12 insertions(+), 11 deletions(-)
From translation svn revision: 80958

Authors:
Bernd Dorer <[email protected]>
David Parduhn <[email protected]>
Rene Linke <[email protected]>
Adriani Botez <[email protected]>
Karl Eick <[email protected]>
Robert Hänggi <[email protected]>
Astrid Waldschmetterling <[email protected]>

Stats:
7	6	user_docs/de/changes.md
28	29	user_docs/de/userGuide.md
 2 files changed, 35 insertions(+), 35 deletions(-)
From translation svn revision: 80958

Authors:
Jani Kinnunen <[email protected]>
Isak Sand <[email protected]>

Stats:
2	2	source/locale/fi/symbols.dic
9	8	user_docs/fi/changes.md
18	19	user_docs/fi/userGuide.md
 3 files changed, 29 insertions(+), 29 deletions(-)
From translation svn revision: 80958

Authors:
Michel such <[email protected]>
Remy Ruiz <[email protected]>
Abdelkrim Bensaid <[email protected]>
Cyrille Bougot <[email protected]>
Corentin Bacqué-Cazenave <[email protected]>
Sylvie Duchateau <[email protected]>
Sof <[email protected]>

Stats:
3	1	source/locale/fr/symbols.dic
23	24	user_docs/fr/userGuide.md
 2 files changed, 26 insertions(+), 25 deletions(-)
From translation svn revision: 80958

Authors:
Hrvoje Katic <[email protected]>
Zvonimir Stanecic <[email protected]>
Milo Ivir <[email protected]>
Dejana Rakic <[email protected]>

Stats:
2	2	source/locale/hr/symbols.dic
2	1	user_docs/hr/changes.md
26	27	user_docs/hr/userGuide.md
 3 files changed, 30 insertions(+), 30 deletions(-)
From translation svn revision: 80958

Authors:
Takuya Nishimoto <[email protected]>
Minako Nonogaki <[email protected]>

Stats:
2	1	user_docs/ja/changes.md
0	1	user_docs/ja/userGuide.md
 2 files changed, 2 insertions(+), 2 deletions(-)
From translation svn revision: 80958

Authors:
Bram Duvigneau <[email protected]>
Bart Simons <[email protected]>
A Campen <[email protected]>
Leonard de Ruijter <[email protected]>

Stats:
30	30	user_docs/nl/userGuide.md
 1 file changed, 30 insertions(+), 30 deletions(-)
From translation svn revision: 80958

Authors:
Zvonimir Stanecic <[email protected]>
Aleksandr Lin'kov <[email protected]>

Stats:
2	2	source/locale/ru/symbols.dic
16	17	user_docs/ru/userGuide.md
 2 files changed, 18 insertions(+), 19 deletions(-)
From translation svn revision: 80958

Authors:
Dinakar T.D. <[email protected]>

Stats:
2	2	source/locale/ta/symbols.dic
 1 file changed, 2 insertions(+), 2 deletions(-)
From translation svn revision: 80958

Authors:
Volodymyr Pyrig <[email protected]>

Stats:
2	2	source/locale/uk/symbols.dic
7	5	user_docs/uk/changes.md
51	52	user_docs/uk/userGuide.md
 3 files changed, 60 insertions(+), 59 deletions(-)
From translation svn revision: 80958

Authors:
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

Stats:
73	70	user_docs/zh_CN/changes.md
 1 file changed, 73 insertions(+), 70 deletions(-)
From translation svn revision: 80958
Update translations
Fixup of nvaccess#16521
Fixes nvaccess#11570
Partial fix for nvaccess#4631

Summary of the issue:
It turns out that rawTextTypeforms on a region may be None, this was an oversight on my end.
cursorPos may also be None.
@burmancomp reported a zero division error in case a string ended with a non breaking space and a space.
Description of user facing changes
No longer errors in the log when getting flash messages in Thunderbird and/or reading messages in WhatsApp UWP.

Description of development approach
Explicitly check for None typeforms and cursorPos, thereby improving readability as well.
Improve the calculateOffsets method in textUtils to ensure it can handle the case as reported by @burmancomp
add base release blurb, update change log
SaschaCowley and others added 27 commits July 4, 2024 15:47
From translation svn revision: 82312

Authors:
Bernd Dorer <[email protected]>
David Parduhn <[email protected]>
Rene Linke <[email protected]>
Adriani Botez <[email protected]>
Karl Eick <[email protected]>
Robert Hänggi <[email protected]>
Astrid Waldschmetterling <[email protected]>

Stats:
330	222	user_docs/de/changes.md
150	61	user_docs/de/userGuide.md
 2 files changed, 480 insertions(+), 283 deletions(-)
From translation svn revision: 82312

Authors:
Juan C. buno <[email protected]>
Noelia Martinez <[email protected]>
Remy Ruiz <[email protected]>
Jose M. Delicado <[email protected]>

Stats:
119	19	user_docs/es/changes.md
105	20	user_docs/es/userGuide.md
 2 files changed, 224 insertions(+), 39 deletions(-)
From translation svn revision: 82312

Authors:
Jani Kinnunen <[email protected]>
Isak Sand <[email protected]>

Stats:
85	0	user_docs/fi/changes.md
115	26	user_docs/fi/userGuide.md
 2 files changed, 200 insertions(+), 26 deletions(-)
From translation svn revision: 82312

Authors:
Michel such <[email protected]>
Remy Ruiz <[email protected]>
Abdelkrim Bensaid <[email protected]>
Cyrille Bougot <[email protected]>
Corentin Bacque-Cazenave <[email protected]>
Sylvie Duchateau <[email protected]>
Sof <[email protected]>

Stats:
112	23	user_docs/fr/userGuide.md
 1 file changed, 112 insertions(+), 23 deletions(-)
From translation svn revision: 82312

Authors:
Juan C. buno <[email protected]>
Ivan Novegil <[email protected]>
Javier Curras <[email protected]>
Jose M. Delicado <[email protected]>

Stats:
100	0	user_docs/gl/changes.md
94	9	user_docs/gl/userGuide.md
 2 files changed, 194 insertions(+), 9 deletions(-)
From translation svn revision: 82312

Authors:
Hrvoje Katic <[email protected]>
Zvonimir Stanecic <[email protected]>
Milo Ivir <[email protected]>
Dejana Rakic <[email protected]>

Stats:
82	0	user_docs/hr/changes.md
103	14	user_docs/hr/userGuide.md
 2 files changed, 185 insertions(+), 14 deletions(-)
From translation svn revision: 82312

Authors:
Takuya Nishimoto <[email protected]>
Minako Nonogaki <[email protected]>

Stats:
106	17	user_docs/ja/userGuide.md
 1 file changed, 106 insertions(+), 17 deletions(-)
From translation svn revision: 82312

Authors:
Zvonimir Stanecic <[email protected]>
Aleksandr Lin'kov <[email protected]>

Stats:
100	0	user_docs/ru/changes.md
102	13	user_docs/ru/userGuide.md
 2 files changed, 202 insertions(+), 13 deletions(-)
From translation svn revision: 82312

Authors:
Cagri Dogan <[email protected]>

Stats:
1	0	user_docs/tr/changes.md
 1 file changed, 1 insertion(+)
From translation svn revision: 82312

Authors:
Dang Hoai Phuc <[email protected]>
Nguyen Van Dung <[email protected]>

Stats:
1	0	user_docs/vi/changes.md
 1 file changed, 1 insertion(+)
From translation svn revision: 82312
From translation svn revision: 82403

Authors:
Fatma Mehanna <[email protected]>
Shaimaa Ibrahim <[email protected]>
Abdelkrim Bensaid <[email protected]>
Omar Alojaimi <[email protected]>

Stats:
63	0	user_docs/ar/changes.md
 1 file changed, 63 insertions(+)
From translation svn revision: 82403

Authors:
Bernd Dorer <[email protected]>
David Parduhn <[email protected]>
Rene Linke <[email protected]>
Adriani Botez <[email protected]>
Karl Eick <[email protected]>
Robert Hänggi <[email protected]>
Astrid Waldschmetterling <[email protected]>

Stats:
4	3	user_docs/de/userGuide.md
 1 file changed, 4 insertions(+), 3 deletions(-)
From translation svn revision: 82403

Authors:
Jani Kinnunen <[email protected]>
Isak Sand <[email protected]>

Stats:
8	7	user_docs/fi/userGuide.md
 1 file changed, 8 insertions(+), 7 deletions(-)
From translation svn revision: 82403

Authors:
Michel such <[email protected]>
Remy Ruiz <[email protected]>
Abdelkrim Bensaid <[email protected]>
Cyrille Bougot <[email protected]>
Corentin Bacque-Cazenave <[email protected]>
Sylvie Duchateau <[email protected]>
Sof <[email protected]>

Stats:
3	2	user_docs/fr/userGuide.md
 1 file changed, 3 insertions(+), 2 deletions(-)
From translation svn revision: 82403

Authors:
Hrvoje Katic <[email protected]>
Zvonimir Stanecic <[email protected]>
Milo Ivir <[email protected]>
Dejana Rakic <[email protected]>

Stats:
1	0	user_docs/hr/userGuide.md
 1 file changed, 1 insertion(+)
From translation svn revision: 82403

Authors:
Bram Duvigneau <[email protected]>
Bart Simons <[email protected]>
A Campen <[email protected]>
Leonard de Ruijter <[email protected]>

Stats:
126	71	user_docs/nl/userGuide.md
 1 file changed, 126 insertions(+), 71 deletions(-)
From translation svn revision: 82403

Authors:
Patryk Faliszewski <[email protected]>
Zvonimir Stanecic <[email protected]>
Dorota Krac <[email protected]>
Piotr Rakowski <[email protected]>
Hubert Meyer <[email protected]>
Arkadiusz Swietnicki <[email protected]>

Stats:
82	1	user_docs/pl/changes.md
105	15	user_docs/pl/userGuide.md
 2 files changed, 187 insertions(+), 16 deletions(-)
From translation svn revision: 82403

Authors:
Zvonimir Stanecic <[email protected]>
Aleksandr Lin'kov <[email protected]>

Stats:
67	66	user_docs/ru/userGuide.md
 1 file changed, 67 insertions(+), 66 deletions(-)
From translation svn revision: 82403
zstanecic
Contributor
zstanecic commented yesterday • 
Link to issue number:
fixes nvaccess#16773

Summary of the issue:
This pull request adds the International phonetic alphabet braille table inly on output, as requested in the issue referenced above.

Description of user facing changes
Added new International phonetic alphabet braille table in the braille settings dialog, output braille table section

Description of development approach
Changed the brailleTables.py and changes.t2t accordingly, all this based on the beta branch, targeted to 2024.3
Some fixes seen in NVDA's user guide during translation.

Description of user facing changes
See User Guide
Update translation for documentation
@SaschaCowley SaschaCowley deleted the brailleFormatting-underline branch August 22, 2024 05:38
SaschaCowley pushed a commit that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.