Skip to content

Commit

Permalink
Update target os name due to RHELC-1737
Browse files Browse the repository at this point in the history
  • Loading branch information
shweta83 committed Dec 19, 2024
1 parent ac6afaf commit 1bf68ea
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 3 deletions.
2 changes: 1 addition & 1 deletion robottelo/utils/issue_handlers/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Methods related to issue handlers in general
from robottelo.utils.issue_handlers import bugzilla, jira

handler_methods = {'BZ': bugzilla.is_open_bz, 'SAT': jira.is_open_jira}
handler_methods = {'BZ': bugzilla.is_open_bz, 'SAT': jira.is_open_jira, 'RHELC': jira.is_open_jira}
SUPPORTED_HANDLERS = tuple(f"{handler}" for handler in handler_methods)


Expand Down
15 changes: 13 additions & 2 deletions tests/foreman/api/test_convert2rhel.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

from robottelo.config import settings
from robottelo.constants import DEFAULT_ARCHITECTURE, REPOS
from robottelo.utils.issue_handlers import is_open


def create_repo(sat, org, repo_url, ssl_cert=None):
Expand Down Expand Up @@ -328,7 +329,12 @@ def test_convert2rhel_oracle_with_pre_conversion_template_check(
assert host_content['facts']['conversions::success'] == 'true'
convert2rhel_facts = json.loads(oracle.execute('cat /etc/rhsm/facts/convert2rhel.facts').stdout)
assert convert2rhel_facts['conversions.env.CONVERT2RHEL_THROUGH_FOREMAN'] == '1'
assert target_os_name in convert2rhel_facts['conversions.target_os.name']
# https://issues.redhat.com/browse/RHELC-1737
assert (
"Oracle"
if is_open('RHELC-1737')
else target_os_name in convert2rhel_facts['conversions.target_os.name']
)
assert convert2rhel_facts['conversions.success'] is True


Expand Down Expand Up @@ -422,5 +428,10 @@ def test_convert2rhel_centos_with_pre_conversion_template_check(
assert host_content['facts']['conversions::success'] == 'true'
convert2rhel_facts = json.loads(centos.execute('cat /etc/rhsm/facts/convert2rhel.facts').stdout)
assert convert2rhel_facts['conversions.env.CONVERT2RHEL_THROUGH_FOREMAN'] == '1'
assert target_os_name in convert2rhel_facts['conversions.target_os.name']
# https://issues.redhat.com/browse/RHELC-1737
assert (
"CentOS"
if is_open('RHELC-1737')
else target_os_name in convert2rhel_facts['conversions.target_os.name']
)
assert convert2rhel_facts['conversions.success'] is True

0 comments on commit 1bf68ea

Please sign in to comment.