code coverage bug2063218 #14308

yanpliu · 2024-03-08T06:41:58Z

Code coverage bug2063218, it is a new [RFE]
Test case : PASS

(robottelo_vv_615) [root@dell-per740-68-vm-05 robottelo]# pytest ./tests/foreman/virtwho/cli/test_esx_sca.py -k test_positive_rhsm_username_option --disable-pytest-warnings -q
.                                                                                                                                                                                                                                      [100%]
1 passed, 39 deselected, 23 warnings in 450.60s (0:07:30)

tests/foreman/virtwho/cli/test_esx_sca.py

lhellebr

I tried to rephrase the comments and docstring because I had a hard time understanding them. Please correct me if my edits are factually incorrect.

tests/foreman/virtwho/cli/test_esx_sca.py

Co-authored-by: Lukáš Hellebrandt <[email protected]>

yanpliu · 2024-03-29T03:04:55Z

tried to rephrase the comments and docstring because I had a hard time understanding them. Please correct me if my edits are factually incorrect.
Thank you very much for your comments and suggestions ,have already submit the suggestions

lhellebr

Looks much better now, thanks!

tests/foreman/virtwho/cli/test_esx_sca.py

robottelo/utils/virtwho.py

tests/foreman/virtwho/cli/test_esx_sca.py

Gauravtalreja1 · 2024-04-25T10:55:34Z

tests/foreman/virtwho/cli/test_esx_sca.py

+            f"Authenticating with RHSM username {rhsm_username[0]}",
+            f"Authenticating with RHSM username {rhsm_username[2]}",
+            f"Host-to-guest mapping being sent to '{module_sca_manifest_org.name}'",


Please use single quotes wherever possible, to ensure consistency :)

@Gauravtalreja1 Thank you very much for your suggestion, this used double quotes , it is because there is single quotes in the string, so used double quotes.

@yanpliu yes, but we can switch it with single quotes with double quotes inside, but I wouldn't block this PR merge for it

Co-authored-by: Gaurav Talreja <[email protected]>

jyejare

I am good with framework changes.

* code coverage bug2063218 * update loop&check message&duplicated code etc * Update the descriptions for expectresults * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * update code to fix repeating anti-pattern * Update the comments * Update robottelo/utils/virtwho.py Co-authored-by: Gaurav Talreja <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Gaurav Talreja <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Gaurav Talreja <[email protected]> --------- Co-authored-by: Lukáš Hellebrandt <[email protected]> Co-authored-by: Gaurav Talreja <[email protected]> (cherry picked from commit cc3c119)

code coverage bug2063218 (#14308) * code coverage bug2063218 * update loop&check message&duplicated code etc * Update the descriptions for expectresults * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * update code to fix repeating anti-pattern * Update the comments * Update robottelo/utils/virtwho.py Co-authored-by: Gaurav Talreja <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Gaurav Talreja <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Gaurav Talreja <[email protected]> --------- Co-authored-by: Lukáš Hellebrandt <[email protected]> Co-authored-by: Gaurav Talreja <[email protected]> (cherry picked from commit cc3c119) Co-authored-by: yanpliu <[email protected]>

* code coverage bug2063218 * update loop&check message&duplicated code etc * Update the descriptions for expectresults * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Lukáš Hellebrandt <[email protected]> * update code to fix repeating anti-pattern * Update the comments * Update robottelo/utils/virtwho.py Co-authored-by: Gaurav Talreja <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Gaurav Talreja <[email protected]> * Update tests/foreman/virtwho/cli/test_esx_sca.py Co-authored-by: Gaurav Talreja <[email protected]> --------- Co-authored-by: Lukáš Hellebrandt <[email protected]> Co-authored-by: Gaurav Talreja <[email protected]>

code coverage bug2063218

af59aa5

yanpliu added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Mar 8, 2024

yanpliu self-assigned this Mar 8, 2024

yanpliu requested a review from a team as a code owner March 8, 2024 06:41

lhellebr requested changes Mar 12, 2024

View reviewed changes

update loop&check message&duplicated code etc

b8e7427

yanpliu requested a review from a team as a code owner March 14, 2024 05:49

yanpliu requested a review from lhellebr March 20, 2024 02:24

Update the descriptions for expectresults

be4ab9a

lhellebr reviewed Mar 25, 2024

View reviewed changes

yanpliu and others added 10 commits March 29, 2024 09:28

Update tests/foreman/virtwho/cli/test_esx_sca.py

553d1d5

Co-authored-by: Lukáš Hellebrandt <[email protected]>

Update tests/foreman/virtwho/cli/test_esx_sca.py

ae632f0

Co-authored-by: Lukáš Hellebrandt <[email protected]>

Update tests/foreman/virtwho/cli/test_esx_sca.py

8d0ee36

Co-authored-by: Lukáš Hellebrandt <[email protected]>

Update tests/foreman/virtwho/cli/test_esx_sca.py

b17c635

Co-authored-by: Lukáš Hellebrandt <[email protected]>

Update tests/foreman/virtwho/cli/test_esx_sca.py

2789fd0

Co-authored-by: Lukáš Hellebrandt <[email protected]>

Update tests/foreman/virtwho/cli/test_esx_sca.py

b4e5361

Co-authored-by: Lukáš Hellebrandt <[email protected]>

Update tests/foreman/virtwho/cli/test_esx_sca.py

26b57db

Co-authored-by: Lukáš Hellebrandt <[email protected]>

Update tests/foreman/virtwho/cli/test_esx_sca.py

f1a8c68

Co-authored-by: Lukáš Hellebrandt <[email protected]>

update code to fix repeating anti-pattern

f400942

Update the comments

6048e58

lhellebr approved these changes Apr 8, 2024

View reviewed changes

tests/foreman/virtwho/cli/test_esx_sca.py Show resolved Hide resolved

Gauravtalreja1 reviewed Apr 25, 2024

View reviewed changes

robottelo/utils/virtwho.py Outdated Show resolved Hide resolved

Gauravtalreja1 reviewed Apr 25, 2024

View reviewed changes

tests/foreman/virtwho/cli/test_esx_sca.py Outdated Show resolved Hide resolved

Gauravtalreja1 reviewed Apr 25, 2024

View reviewed changes

tests/foreman/virtwho/cli/test_esx_sca.py Outdated Show resolved Hide resolved

Gauravtalreja1 reviewed Apr 25, 2024

View reviewed changes

yanpliu and others added 3 commits April 26, 2024 09:09

Update robottelo/utils/virtwho.py

dbdb044

Co-authored-by: Gaurav Talreja <[email protected]>

Update tests/foreman/virtwho/cli/test_esx_sca.py

d94c7c1

Co-authored-by: Gaurav Talreja <[email protected]>

Update tests/foreman/virtwho/cli/test_esx_sca.py

1d99abb

Co-authored-by: Gaurav Talreja <[email protected]>

lhellebr requested review from a team and Gauravtalreja1 April 29, 2024 14:26

yanpliu requested review from mshriver and jyejare May 6, 2024 00:59

jyejare approved these changes May 14, 2024

View reviewed changes

Gauravtalreja1 approved these changes May 14, 2024

View reviewed changes

Gauravtalreja1 merged commit cc3c119 into SatelliteQE:master May 14, 2024
8 checks passed

Satellite-QE mentioned this pull request May 14, 2024

[6.15.z] code coverage bug2063218 #15059

Merged

yanpliu deleted the codecoverage_2063218 branch May 15, 2024 03:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

code coverage bug2063218 #14308

code coverage bug2063218 #14308

yanpliu commented Mar 8, 2024

lhellebr left a comment

yanpliu commented Mar 29, 2024

lhellebr left a comment

Gauravtalreja1 Apr 25, 2024

yanpliu Apr 26, 2024

Gauravtalreja1 May 14, 2024

jyejare left a comment

code coverage bug2063218 #14308

code coverage bug2063218 #14308

Conversation

yanpliu commented Mar 8, 2024

lhellebr left a comment

Choose a reason for hiding this comment

yanpliu commented Mar 29, 2024

lhellebr left a comment

Choose a reason for hiding this comment

Gauravtalreja1 Apr 25, 2024

Choose a reason for hiding this comment

yanpliu Apr 26, 2024

Choose a reason for hiding this comment

Gauravtalreja1 May 14, 2024

Choose a reason for hiding this comment

jyejare left a comment

Choose a reason for hiding this comment