Add test for host registration using capsule cname #15629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shweta83
added
CherryPick
|
trigger: test-robottelo |
|
PRT Result |
Satellite-QE
added
the
PRT-Failed
|
trigger: test-robottelo |
shweta83
force-pushed
the
host_register_capsule_cname
branch
2 times, most recently
from
e2359fa
to
20668ca
Compare
|
trigger: test-robottelo |
|
PRT Result |
shweta83
force-pushed
the
host_register_capsule_cname
branch
from
20668ca
to
b485799
Compare
|
trigger: test-robottelo |
|
PRT Result |
Satellite-QE
added
PRT-Passed
shweta83
force-pushed
the
host_register_capsule_cname
branch
from
b485799
to
6d5ec34
Compare
Satellite-QE
removed
the
PRT-Passed
shweta83
force-pushed
the
host_register_capsule_cname
branch
from
6d5ec34
to
145b7c0
Compare
|
trigger: test-robottelo |
|
PRT Result |
Satellite-QE
added
the
PRT-Passed
Comment on lines
+508
to
+510
| result = rhel_contenthost.execute( | ||
| re.sub(r"https://ip.*?redhat\.com", f'https://{capsule_cname}', command) | ||
| ) |
There was a problem hiding this comment.
why hardcoding the url? could you try something similar,
Suggested change
| result = rhel_contenthost.execute( | |
| re.sub(r"https://ip.*?redhat\.com", f'https://{capsule_cname}', command) | |
| ) | |
| result = rhel_contenthost.execute( | |
| command.replace(module_capsule_configured.hostname, capsule_cname) | |
| ) |
Comment on lines
+494
to
+498
| rhel_contenthost.execute( | ||
| f'echo "{module_capsule_configured.ip} {module_capsule_configured.hostname} {capsule_cname}' | ||
| f'" >> /etc/hosts' | ||
| ) | ||
|
|
There was a problem hiding this comment.
isn't there any direct way from smart_proxy to handle setting the cname's?
|
|
||
| :parametrized: yes | ||
| """ | ||
| capsule_cname = "capsule.example.com" |
There was a problem hiding this comment.
Suggested change
| capsule_cname = "capsule.example.com" | |
| capsule_cname = 'capsule.example.com' |
| @@ -445,3 +446,66 @@ def test_positive_katello_ca_crt_refresh( | |||
| # check if the certificate file is refreshed | |||
| ca_file_after_refresh = len(str(rhel_contenthost.execute(f'cat {katello_ca_crt_path}'))) | |||
| assert ca_cert_file == ca_file_after_refresh | |||
|
|
|||
|
|
|||
| @pytest.mark.rhel_ver_match('[^7]') | |||
There was a problem hiding this comment.
is it really required to run for all rhel versions? I feel default should be suffice to test
| module_activation_key, | ||
| module_capsule_configured, | ||
| ): | ||
| """Verify host registration works with proxy and proxy_cname |
There was a problem hiding this comment.
we're just testing with proxy_cname here, right?
Comment on lines
+481
to
+483
| nc = module_capsule_configured.nailgun_smart_proxy | ||
| module_target_sat.api.SmartProxy(id=nc.id, organization=[org]).update(['organization']) | ||
| module_target_sat.api.SmartProxy(id=nc.id, location=[module_location]).update(['location']) |
There was a problem hiding this comment.
Both updates can be done in same call
Suggested change
| nc = module_capsule_configured.nailgun_smart_proxy | |
| module_target_sat.api.SmartProxy(id=nc.id, organization=[org]).update(['organization']) | |
| module_target_sat.api.SmartProxy(id=nc.id, location=[module_location]).update(['location']) | |
| nc = module_capsule_configured.nailgun_smart_proxy | |
| nc.location = [module_location] | |
| nc.organization = [module_org] | |
| nc.update(['organization', 'location']) |
| :id: 86b5c329-7784-43f4-bb67-67ce5a24ce17 | ||
|
|
||
| :steps: | ||
| 1. Get a configure capsule registered with Satellite. |
There was a problem hiding this comment.
Suggested change
| 1. Get a configure capsule registered with Satellite. | |
| 1. Configure external capsule which is registered to Satellite |
|
|
||
| :steps: | ||
| 1. Get a configure capsule registered with Satellite. | ||
| 2. Verify Host registers to Capsule successfully. |
There was a problem hiding this comment.
Host or Capsule? anyway this step can be skipped
|
This pull request has not been updated in the past 45 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for host registration using capsule cname.
BZ#2158959
Related Issues