Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fact names changed in 6.16 #16217

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Update fact names changed in 6.16 #16217

merged 1 commit into from
Sep 17, 2024

Conversation

shweta83
Copy link
Contributor

@shweta83 shweta83 commented Sep 5, 2024 •
edited
Loading

Problem Statement

Names of few fact values have been changed causing test failures
uptime -> system_uptime
uptime_seconds -> system_uptime::seconds
memorysize -> memory::system::total
ipaddress -> networking::ip

Solution

Updated the fact values

Related Issues

@shweta83 shweta83 requested a review from a team as a code owner September 5, 2024 08:02
@shweta83 shweta83 added TestFailure Issues and PRs related to a test failing in automation CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.16.z Introduced in or relating directly to Satellite 6.16 labels Sep 5, 2024
@shweta83
Copy link
Contributor Author

shweta83 commented Sep 5, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_fact.py -k test_positive_list_by_name

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8476
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_fact.py -k test_positive_list_by_name --external-logging
Test Result : ====== 2 failed, 3 passed, 5 deselected, 42 warnings in 657.56s (0:10:57) ======

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Sep 5, 2024
@shweta83
Copy link
Contributor Author

shweta83 commented Sep 5, 2024 

trigger: test-robottelo
pytest: tests/foreman/cli/test_fact.py -k test_positive_list_by_name
env:
  ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.16.0'
  ROBOTTELO_server__deploy_arguments__deploy_snap_version: '2.0'
  ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '8'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8477
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_fact.py -k test_positive_list_by_name --external-logging
Test Result : ====== 2 failed, 3 passed, 5 deselected, 43 warnings in 626.15s (0:10:26) ======

@shweta83
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_fact.py -k test_positive_list_by_name
env:
  ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.16.0'
  ROBOTTELO_server__deploy_arguments__deploy_snap_version: '4.0'
  ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '8'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8673
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_fact.py -k test_positive_list_by_name --external-logging
Test Result : ====== 2 failed, 3 passed, 5 deselected, 42 warnings in 647.88s (0:10:47) ======

@shweta83
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_fact.py -k test_positive_list_by_name
env:
  ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.16.0'
  ROBOTTELO_server__deploy_arguments__deploy_snap_version: '4.0'
  ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '8'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8683
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_fact.py -k test_positive_list_by_name --external-logging
Test Result : =========== 5 passed, 5 deselected, 41 warnings in 644.01s (0:10:44) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Sep 17, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8684
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_fact.py -k test_positive_list_by_name --external-logging
Test Result : =========== 5 passed, 5 deselected, 41 warnings in 639.17s (0:10:39) ===========

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Sep 17, 2024
@shweta83
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_fact.py -k test_positive_list_by_name
env:
  ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.16.0'
  ROBOTTELO_server__deploy_arguments__deploy_snap_version: '4.0'
  ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '8'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8685
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_fact.py -k test_positive_list_by_name --external-logging
Test Result : =========== 5 passed, 5 deselected, 41 warnings in 640.18s (0:10:40) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Sep 17, 2024
@shubhamsg199 shubhamsg199 merged commit 55c2814 into SatelliteQE:master Sep 17, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 17, 2024
@shweta83 @web-flow
Update fact names changed in 6.16 (#16217)
eb0b0de 
(cherry picked from commit 55c2814)
@Satellite-QE Satellite-QE mentioned this pull request Sep 17, 2024
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@shweta83 @jyejare
Update fact names changed in 6.16 (SatelliteQE#16217)
dc60bb7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

@pondrejk pondrejk pondrejk approved these changes

Assignees

@shweta83 shweta83

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shweta83 @Satellite-QE @pondrejk @shubhamsg199