Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use client-2 repo against Satellite 6.16+ #16397

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Use client-2 repo against Satellite 6.16+ #16397

merged 1 commit into from
Sep 18, 2024

Conversation

lpramuk
Copy link
Contributor

@lpramuk lpramuk commented Sep 18, 2024

Problem Statement

Satellite 6.16 includes Puppet 8 so there is now new Client-2 repo that provides Puppet 8 agent while Client repo continues to provide Puppet 7 agent.

Solution

Use Client-2 repo when running against Satellite 6.16 and newer

Related Issues

@lpramuk lpramuk added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.16.z labels Sep 18, 2024
@lpramuk lpramuk self-assigned this Sep 18, 2024
@lpramuk lpramuk requested a review from a team as a code owner September 18, 2024 09:46
ogajduse
ogajduse approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for PRT run and results.

@lpramuk lpramuk force-pushed the client-2_repo branch 2 times, most recently from 45a6543 to 05a1020 Compare September 18, 2024 10:11
@lpramuk
Copy link
Contributor Author

lpramuk commented Sep 18, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_report.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8698
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_report.py --external-logging
Test Result : ================= 7 passed, 181 warnings in 3254.15s (0:54:14) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Sep 18, 2024
@lpramuk lpramuk changed the title Use client-2 repo against Satellite 6.16+ NO MERGE: Use client-2 repo against Satellite 6.16+ Sep 18, 2024
@lpramuk lpramuk changed the title NO MERGE: Use client-2 repo against Satellite 6.16+ Use client-2 repo against Satellite 6.16+ Sep 18, 2024
@jameerpathan111 jameerpathan111 merged commit a26dde1 into SatelliteQE:master Sep 18, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 18, 2024
@lpramuk @web-flow
Use client-2 repo against Satellite 6.16+ (#16397)
afaa66b 
(cherry picked from commit a26dde1)
@Satellite-QE Satellite-QE mentioned this pull request Sep 18, 2024
Merged
jameerpathan111 pushed a commit that referenced this pull request Sep 18, 2024
@Satellite-QE @lpramuk
[6.16.z] Use client-2 repo against Satellite 6.16+ (#16409)
874d9ef 
Use client-2 repo against Satellite 6.16+ (#16397)

(cherry picked from commit a26dde1)

Co-authored-by: Lukas Pramuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogajduse ogajduse ogajduse approved these changes

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

Assignees

@lpramuk lpramuk

Labels
6.16.z AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpramuk @Satellite-QE @ogajduse @jameerpathan111