Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing provisioning tests #16414

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix failing provisioning tests #16414

merged 1 commit into from
Sep 26, 2024

Conversation

shubhamsg199
Copy link
Contributor

@shubhamsg199 shubhamsg199 commented Sep 18, 2024 •
edited
Loading

Problem Statement

Provisioning tests are failing due to uncleaned dhcp leases in the satellite due to recent infra change

Solution

Handle the lease cleanup and fix them

Related Issues

@shubhamsg199 shubhamsg199 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Sep 18, 2024
@shubhamsg199 shubhamsg199 self-assigned this Sep 18, 2024
@shubhamsg199 shubhamsg199 requested a review from a team as a code owner September 18, 2024 15:56
@shubhamsg199 shubhamsg199 marked this pull request as draft September 18, 2024 15:56
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8728
Build Status: UNSTABLE
PRT Comment: pytest -m on_premises_provisioning tests/foreman/ --include-onprem-provisioning --external-logging --include-onprem-provisioning
Test Result : = 49 failed, 40 passed, 6 skipped, 5354 deselected, 17214 warnings, 1 error in 99063.32s (1 day, 3:31:03) =

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Sep 20, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8751
Build Status: UNSTABLE
PRT Comment: pytest -m on_premises_provisioning tests/foreman/ --include-onprem-provisioning --external-logging --include-onprem-provisioning
Test Result : = 9 failed, 22 passed, 6 skipped, 5354 deselected, 11408 warnings, 59 errors in 43023.21s (11:57:03) =

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8758
Build Status: UNSTABLE
PRT Comment: pytest -m on_premises_provisioning tests/foreman/ --include-onprem-provisioning --external-logging --include-onprem-provisioning
Test Result : = 28 failed, 58 passed, 6 skipped, 5354 deselected, 17043 warnings, 4 errors in 104204.13s (1 day, 4:56:44) =

@shubhamsg199 shubhamsg199 marked this pull request as ready for review September 23, 2024 10:32
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8783
Build Status: UNSTABLE
PRT Comment: pytest -m on_premises_provisioning tests/foreman/api/test_discoveredhost.py tests/foreman/cli/test_discoveredhost.py tests/foreman/ui/test_discoveredhost.py --include-onprem-provisioning --external-logging --include-onprem-provisioning
Test Result : = 6 failed, 9 passed, 22 deselected, 2922 warnings, 8 errors in 19258.20s (5:20:58) =

@shubhamsg199
Fix_failing_provisioning_tests
6ecb7d2 
Signed-off-by: Shubham Ganar <[email protected]>
@shubhamsg199 shubhamsg199 force-pushed the Fix-dhcp/leases-provisioning-issue branch from 28a4843 to 6ecb7d2 Compare September 26, 2024 15:51
@shubhamsg199 shubhamsg199 added 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Sep 26, 2024
@SatelliteQE SatelliteQE deleted a comment from devendra104 Sep 26, 2024
@shubhamsg199
Copy link
Contributor Author

shubhamsg199 commented Sep 26, 2024 •
edited
Loading

As discussed with @Gauravtalreja1, Deleting old PRT comments as we are not looking to run PRT on old cherrypicked versions.

@Gauravtalreja1 Gauravtalreja1 merged commit 02fb4ae into SatelliteQE:master Sep 26, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
@shubhamsg199 @web-flow
Fix failing provisioning tests (#16414)
d6da10b 
Fix_failing_provisioning_tests

Signed-off-by: Shubham Ganar <[email protected]>
(cherry picked from commit 02fb4ae)
github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
@shubhamsg199 @web-flow
Fix failing provisioning tests (#16414)
4fe85a0 
Fix_failing_provisioning_tests

Signed-off-by: Shubham Ganar <[email protected]>
(cherry picked from commit 02fb4ae)
github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
@shubhamsg199 @web-flow
Fix failing provisioning tests (#16414)
ccd7c88 
Fix_failing_provisioning_tests

Signed-off-by: Shubham Ganar <[email protected]>
(cherry picked from commit 02fb4ae)
This was referenced Sep 26, 2024
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
@shubhamsg199 @web-flow
Fix failing provisioning tests (#16414)
fa85cc1 
Fix_failing_provisioning_tests

Signed-off-by: Shubham Ganar <[email protected]>
(cherry picked from commit 02fb4ae)
This was referenced Sep 26, 2024
Merged
Merged
Gauravtalreja1 pushed a commit that referenced this pull request Sep 26, 2024
@Satellite-QE @shubhamsg199
[6.16.z] Fix failing provisioning tests (#16510)
b10b00c 
Fix failing provisioning tests (#16414)

Fix_failing_provisioning_tests

Signed-off-by: Shubham Ganar <[email protected]>
(cherry picked from commit 02fb4ae)

Co-authored-by: Shubham Ganar <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Sep 26, 2024
@Satellite-QE @shubhamsg199
[6.15.z] Fix failing provisioning tests (#16512)
5e113fe 
Fix failing provisioning tests (#16414)

Fix_failing_provisioning_tests

Signed-off-by: Shubham Ganar <[email protected]>
(cherry picked from commit 02fb4ae)

Co-authored-by: Shubham Ganar <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Sep 26, 2024
@Satellite-QE @shubhamsg199
[6.14.z] Fix failing provisioning tests (#16509)
109454e 
Fix failing provisioning tests (#16414)

Fix_failing_provisioning_tests

Signed-off-by: Shubham Ganar <[email protected]>
(cherry picked from commit 02fb4ae)

Co-authored-by: Shubham Ganar <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Sep 26, 2024
@Satellite-QE @shubhamsg199
[6.13.z] Fix failing provisioning tests (#16511)
82439fd 
Fix failing provisioning tests (#16414)

Fix_failing_provisioning_tests

Signed-off-by: Shubham Ganar <[email protected]>
(cherry picked from commit 02fb4ae)

Co-authored-by: Shubham Ganar <[email protected]>
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@shubhamsg199 @jyejare
Fix failing provisioning tests (SatelliteQE#16414)
9f7a4f6 
Fix_failing_provisioning_tests

Signed-off-by: Shubham Ganar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@shubhamsg199 shubhamsg199

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubhamsg199 @Satellite-QE @Gauravtalreja1