-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some basic fixes for 3.6 better support #41
base: master
Are you sure you want to change the base?
Conversation
d041a15
to
a259479
Compare
bfcc4dd
to
348b413
Compare
348b413
to
221b166
Compare
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
+ Coverage 57.61% 57.77% +0.16%
==========================================
Files 12 12
Lines 722 720 -2
==========================================
Hits 416 416
+ Misses 306 304 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, non-blocking question
requirements.txt
Outdated
python_bugzilla==1.2.2 | ||
six==1.10.0 | ||
-e . | ||
python-bugzilla>=1.2.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unpinning the version? What's the reason behind this, why not pinning newer one instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we only say here that we want to use python-bugzilla>=1.2.2 as we intensively tested from this version, please look at robottelo requirements.txt on python-bugzilla version we have to test functionality of new versions before, for scaning the latest versions are working as expected but for other things we have to test robottelo functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get it. robottelo's requirements.txt has pinned python_bugzilla==1.2.2
and the comment there says newer versions have changes which should be tested first. Then why unpinning the version, have you tested new version and updated robozilla accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version has to be pinned by robottelo (and is pinned by roboottelo) not by bugzilla (the version has not to be pinned by the lib).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So robozilla fully supports new versions of python-bugzilla, it's only robottelo who needs an update? btw, could you pls share any test results then?
@pgagne this does not resolve the issue, but unlock the usage for newer versions, and we can implement that feature here by openeing a new issue and if we go with newer version in robottelo (that is pinned to version python-bugzilla==1.2.2) we can use that feature in robottelo too. |
4a279ff
to
9d9774f
Compare
9d9774f
to
272f92e
Compare
Also Closes #40