Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some basic fixes for 3.6 better support #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ldjebran
Copy link
Contributor

@ldjebran ldjebran commented Jan 24, 2019

Also Closes #40

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #41 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   57.61%   57.77%   +0.16%     
==========================================
  Files          12       12              
  Lines         722      720       -2     
==========================================
  Hits          416      416              
+ Misses        306      304       -2
Impacted Files Coverage Δ
robozilla/bz.py 29.65% <ø> (+0.34%) ⬆️
robozilla/query/exp.py 61.85% <100%> (ø) ⬆️
robozilla/filters/decorator.py 100% <100%> (ø) ⬆️
robozilla/parser.py 72.36% <100%> (ø) ⬆️
robozilla/filters/isopen.py 100% <100%> (ø) ⬆️
robozilla/decorators/__init__.py 74.86% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf6f599...272f92e. Read the comment docs.

Copy link
Contributor

@abalakh abalakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, non-blocking question

requirements.txt Outdated
python_bugzilla==1.2.2
six==1.10.0
-e .
python-bugzilla>=1.2.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unpinning the version? What's the reason behind this, why not pinning newer one instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only say here that we want to use python-bugzilla>=1.2.2 as we intensively tested from this version, please look at robottelo requirements.txt on python-bugzilla version we have to test functionality of new versions before, for scaning the latest versions are working as expected but for other things we have to test robottelo functionality

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it. robottelo's requirements.txt has pinned python_bugzilla==1.2.2 and the comment there says newer versions have changes which should be tested first. Then why unpinning the version, have you tested new version and updated robozilla accordingly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version has to be pinned by robottelo (and is pinned by roboottelo) not by bugzilla (the version has not to be pinned by the lib).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So robozilla fully supports new versions of python-bugzilla, it's only robottelo who needs an update? btw, could you pls share any test results then?

@pgagne
Copy link

pgagne commented Feb 21, 2019

@ldjebran @abalakh Curious if this might help with #43 and #44 .

@SatelliteQE/quality-engineers Can we get this merged?

@ldjebran
Copy link
Contributor Author

ldjebran commented Feb 25, 2019

@pgagne this does not resolve the issue, but unlock the usage for newer versions, and we can implement that feature here by openeing a new issue and if we go with newer version in robottelo (that is pinned to version python-bugzilla==1.2.2) we can use that feature in robottelo too.

@ldjebran ldjebran force-pushed the some_basic_fixes branch 3 times, most recently from 4a279ff to 9d9774f Compare December 27, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ErrorString is not an Exception
3 participants