Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] : Add Search Feature & song #252

Merged

Conversation

sivaprasath2004
Copy link
Contributor

Description

Hello @Satyam1923 ,
fixes #55

  • This PR does the following:
    • Adds .. Search Result Suggestions

Related Issues

Link any related issues using the format Fixes #issue_number.
This helps to automatically close related issues when the PR is merged.

Changes

List the detailed changes made in this PR.

  • Added a new feature to user can search song name by suggest for the names.

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

  1. Pull this branch.
  2. Run npm install to install dependencies.
  3. Run npm test to execute the test suite.
  4. Verify that ... 💯

Screenshots (if applicable)

Screencast.from.2024-06-04.19-46-21.webm

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spring-music-player ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 2:05pm
spring-music-player-3hyj ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 2:05pm

Copy link

vercel bot commented Jun 4, 2024

@sivaprasath2004 is attempting to deploy a commit to the satyam1923's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @sivaprasath2004! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We'd also like to invite you to our Discord server! Join us here.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Satyam1923
Copy link
Owner

@sivaprasath2004 remove the suggestions bar which given browsers which firstly shown before your suggestions.

@Satyam1923
Copy link
Owner

@sivaprasath2004 resolve these conflicts.

@sivaprasath2004
Copy link
Contributor Author

@Satyam1923 resolved

@Satyam1923
Copy link
Owner

@sivaprasath2004 how are we actually getting these suggestions?

@sivaprasath2004
Copy link
Contributor Author

Hello @Satyam1923 ,we will search song name s these to suggest for matching song name in s letter.

@Satyam1923
Copy link
Owner

Screenshot 2024-06-06 110447
How you'll fix these two suggestions at a same time.

@sivaprasath2004
Copy link
Contributor Author

@Satyam1923 ,

Screenshot from 2024-06-06 12-33-23

This is U will search already in the search bar ( story of life,stay and Skin and Bones) this is browser suggest.

  • If i will implement, this
    Screenshot from 2024-06-06 12-34-54

@Satyam1923
Copy link
Owner

@sivaprasath2004 can't we use autocomplete = "off" for this?

@sivaprasath2004
Copy link
Contributor Author

@Satyam1923 , isn't show for me
Screenshot from 2024-06-06 12-33-23

  • If you can click to Inspect for what is the additional Suggest?

@Satyam1923
Copy link
Owner

@sivaprasath2004 leave for now resolve conflicts then i'll merge this PR.

@sivaprasath2004
Copy link
Contributor Author

@Satyam1923 resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] : Add Search Feature & song
2 participants