Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit test for checking error response without code #684

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nguyentoanit
Copy link
Collaborator

No description provided.

@nguyentoanit
Copy link
Collaborator Author

@moltar :
In reality, I think it will not occur these cases (on line 110 and 121).

Axios parses the response based on the HTTP response's Content-Type header. Therefore, data will either json object or empty string.

How do you think?

Ref:

@moltar
Copy link
Contributor

moltar commented Jan 15, 2021

I think I am not understanding the intent here. Feels like we are maybe putting too much faith into Amazon returning correct headers and data.

I've seen on the SP API where they return an error with 200 status. :)

Ping me on Slack when you have a minute, let's go over this live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants