Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing metrics and report type to sd report #771

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nguyentoanit
Copy link
Collaborator

No description provided.

@nguyentoanit nguyentoanit self-assigned this May 25, 2021
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #771 (9d62bec) into master (4de24c4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #771      +/-   ##
==========================================
- Coverage   93.23%   93.21%   -0.02%     
==========================================
  Files          94       94              
  Lines        1404     1401       -3     
  Branches       48       48              
==========================================
- Hits         1309     1306       -3     
  Misses         93       93              
  Partials        2        2              
Impacted Files Coverage Δ
...splay/sponsored-display-ad-group-report-metrics.ts 100.00% <ø> (ø)
...splay/sponsored-display-campaign-report-metrics.ts 100.00% <ø> (ø)
...ay/sponsored-display-product-ads-report-metrics.ts 100.00% <ø> (ø)
...display/sponsored-display-target-report-metrics.ts 100.00% <ø> (ø)
src/operations/reports/report-types.ts 100.00% <ø> (ø)
...ored-display/sponsored-display-report-operation.ts 100.00% <ø> (ø)
...rations/reports/metrics/sponsored-display/index.ts 100.00% <100.00%> (ø)
...d-display/sponsored-display-asin-report-metrics.ts 100.00% <100.00%> (ø)
src/operations/reports/sponsored-display/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4de24c4...9d62bec. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant