Cairo support #31
Merged
Cairo support #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringlej
force-pushed
the
jringle/cairo
branch
13 times, most recently
from
6387f93
to
d85d1d7
Compare
ringlej
force-pushed
the
jringle/cairo
branch
2 times, most recently
from
372f16d
to
bd336a6
Compare
ringlej
force-pushed
the
jringle/cairo
branch
7 times, most recently
from
704c03b
to
20e4463
Compare
ringlej
force-pushed
the
jringle/cairo
branch
from
e8b4f28
to
5f6e69e
Compare
|
I added a few commits to fix issues in cairo I encountered while running cairo on our device with a modified version of @axelson hello_scenic_full |
|
There are now only 3 unimplemented functions in cairo_script_ops.c (PR comment updated) |
ringlej
force-pushed
the
jringle/cairo
branch
from
5f6e69e
to
bdd1605
Compare
ringlej
force-pushed
the
jringle/cairo
branch
2 times, most recently
from
c49116a
to
b7aec1f
Compare
|
I've now added some commits that allow building cairo to run on a rpi (tested on rpi3b) |
IMG_8374.2-480-components.movIMG_8374.2-480-primatives.movIMG_8374.2-480-fills.movIMG_8374.2-480-strokes.movIMG_8374.2-480-transforms.mov |
ringlej
force-pushed
the
jringle/cairo
branch
4 times, most recently
from
224279a
to
4e7275b
Compare
This matches what is done similarly in glnvg__allocTexture() in the nvg code to generate ids to use for looking up image data. This change will remove the 32-bit constraint that was previously done with cairo images and allow cairo to build on 64-bit architecture.
This is useful to either run scenic_driver_local with: * gdbserver * valgrind For example, you could now have in your config: `debugger: "gdbserver :5555"` which will wait for you to attach gdb with a remote target on port 5555 and set breakpoints and step through code valgrind is useful for debugging memory issues such as malloc/free, memory overruns and memory leaks.
ringlej
force-pushed
the
jringle/cairo
branch
from
4e7275b
to
d671be2
Compare
crertel
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements all of the script_ops in the scenic -> driver interface.