Scenic loop #54
Merged
Scenic loop #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
crertel
approved these changes
Oct 18, 2023
c_src/scenic/script.c
Outdated
Comment on lines
165
to
170
| static inline unsigned short get_uint16(void* p, uint32_t offset) | ||
| { | ||
| return ntoh_ui16(*((unsigned short*)(p + offset))); | ||
| } | ||
|
|
||
| static inline unsigned int get_uint32( void* p, uint32_t offset ) { | ||
| static inline unsigned int get_uint32(void* p, uint32_t offset) |
There was a problem hiding this comment.
In the return signature, do we want these to be uint32_t instead of unsigned int,etc.?
There was a problem hiding this comment.
I updated this in #53
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on top of #53
This fixes cairo-gtk on macos, where gtk_main() must be run on the Main Thread