Pull in rrectv work #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Ah, hell's bells...okay @ringlej I'm caught back up on this--is there any chance you can grab the Cairo side of this, or should I grab it? I think you've got a bit more context there than I do. |
|
The only thing I'd mention here is that there isn't a Cairo implementation provided so anyone using it with Cairo will get a log message if the function is attempted with no rendering done. |
|
Right now I don't have the cycles to tackle this for Cairo. |
|
Makes sense. Let's do a fast-follow then. (let's here == "Chris will give it a shot later". not trying to give you work!) |
|
'preciate ya, @GPrimola! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes pulling in @GPrimola 's work that I merged in #17 .
We'll rebase here and have staging ground to pull in the functionality to the Cairo backend too.