Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified Docker file and added anndata to environment.yml #5

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Modified Docker file and added anndata to environment.yml #5

merged 2 commits into from
Dec 19, 2023

Conversation

FloWuenne
Copy link
Contributor

Added anndata for development of anndata spatial output for nf-core/molkart.

kbestak
kbestak reviewed Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@kbestak kbestak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for reversion of some aspects of the previous PR?

Dockerfile Show resolved Hide resolved
kbestak
kbestak approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@kbestak kbestak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree that we use the container without the scripts within, I feel that there is use of having the scripts inside for other projects

@kbestak kbestak merged commit cc4922c into main Dec 19, 2023
1 check passed
@kbestak kbestak deleted the anndata_add branch December 19, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbestak kbestak kbestak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FloWuenne @kbestak