Basic support for PostgreSQL materialized views

[jhbaarnh]

Can specify that created views should be materialized. Schema is updated accordingly. Also indices on materialized views are exported to the schema.

[ronen]

Hi, thanks for the PR.

This seems plausible, though the travis build looks like it's breaking. I'll leave it to you to look into that...

And could you also add some specs to test/verify the new capabilities? And add a bit of doc to the README?

All that done I'd be happy to merge

(BTW if you haven't already, take a look at ./runspecs to run the specs locally, it could save you time over waiting for travis)

[jhbaarnh]

Sure, I'll see what I can do. However, I haven't used rspec before, so
it might take a bit of time. I also cannot immediately run runspec, I
see lots of errors of various types, so presumably I need to set up the
environment correctly. Is there a description of what is necessary in
this case?

2014-05-08 13:44, ronen barzel skrev:
Hi, thanks for the PR.

This seems plausible, though the travis build looks like it's breaking.
I'll leave it to you to look into that...

And could you also add some specs to test/verify the new capabilities?
And add a bit of doc to the README?

All that done I'd be happy to mere

(BTW if you haven't already, take a look at ./runspecs to run the specs
locally, it could save you time over waiting for travis)

—
Reply to this email directly or view it on GitHub
#154 (comment).

[ronen]

Oh, the testing instructions were missing from the README for some reason. I've just put them back (and updated them). See Development & Testing at the bottom of the README.

Let me know if you have any questions or problems.

[bamorim]

What if we delegate view options to the adapter and then it constructs for given options.

That is because we can have different possibilities for each type of DB.

For postgres, in example, we can have MATERIALIZED VIEWS, we can also CREATE OR REPLACE a view. So we can expect adapter to have a method build_view_options and each adapter would handle it the way it can.

For example, in PostgreSQL adapter
build_view_options(materialized: true) => MATERIALIZED
build_view_options(replace: true) => OR REPLACE

What do you think?

[forgottentea-xx]

bamorim that is a sweet idea

[ronen]

Closing this out due to lack of activity. But feel free to revive it, albeit now on schema_plus_views (see SchemaPlus/schema_plus_views#9)