Fix: vs-2017.3.host.json: remove allOfand title

[EmilyGraceSeville7cf]

• allOf is redundant with one alternative
• title is redundant with existing title in a referenced schema

[EmilyGraceSeville7cf]

@madskristensen, @GerryFerdinandus, @hyperupcall what's going on? Why CI requests to remove $schema property here and then complains about its removal? markdownlint.json for instance, by this logic should not have CI passed.

[hyperupcall]

@EmilySeville7cfg The purpose of the check is to remove duplication and make things more DRY. When specifying a remote schema with ref, adding $schema is duplicated and it is possible for the reference schema to have a different schema. So we enforce that those files must not contain $schema. (when this check was introduced, it fixed issues with a few existing schemas)

If the schema is declared locally, then we want the $schema to be declared since there are no duplication occurring.

[EmilyGraceSeville7cf]

So, the schema is referenced to should not have schema key?

[hyperupcall]

Yup

[EmilyGraceSeville7cf]

@hyperupcall, vs-2017.3.host.json refers to src/schemas/json/ide.host.json which has $schema. It's impossible to remove $schema from src/schemas/json/ide.host.json. So does it mean that this PR is invalid?

As a side question: why such check for $schema exists if it can be avoided via allOf?

[EmilyGraceSeville7cf]

PR was closed to pay attention for it.