Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2927: remove config schema #2929

Merged

Conversation

EmilyGraceSeville7cf
Copy link
Contributor

closes #2927

@EmilyGraceSeville7cf
Copy link
Contributor Author

EmilyGraceSeville7cf commented Apr 25, 2023

No schema config.json found for test folder => config

It's definitely an unexpected error... 🤔 It seems that it used internally somewhere.

@falsepopsky
Copy link
Contributor

No schema config.json found for test folder => config

It's definitely an unexpected error... 🤔 It seems that it used internally somewhere.

{
"name": "config.json",
"description": "ASP.NET project config file",
"fileMatch": ["config.json"],
"url": "https://json.schemastore.org/config.json"
},

also I think you need to remove the config folder from test

@hyperupcall
Copy link
Member

hyperupcall commented Apr 28, 2023

Commit 82dde22 gives more details about this schema (since the original issue notes uncertainty of its existence), and it appears that a dnx repository exists: https://github.com/aspnet/dnx. I'm not sure if it's old enough to remove, maybe some other people that use aspnet can chime in.

@hyperupcall
Copy link
Member

@EmilySeville7cfg If you remove the test/config directory and repush, then the build should go green

@EmilyGraceSeville7cf
Copy link
Contributor Author

EmilyGraceSeville7cf commented Jun 17, 2023

@hyperupcall, build still fails: git push --force didn't help too.

@hyperupcall
Copy link
Member

@EmilySeville7cfg Because you have to remove it from the catalog.json file too

@EmilyGraceSeville7cf
Copy link
Contributor Author

@madskristensen, PR is ready. ;)

@EmilyGraceSeville7cf
Copy link
Contributor Author

PR was closed to pay attention for it.

@hyperupcall
Copy link
Member

hyperupcall commented Aug 13, 2023

@EmilySeville7cfg This probably went under my radar since GitHub didn't update the CI indicator next to the PR. In the future you may ping me, but please read and fix errors from CI before doing so.

@hyperupcall hyperupcall merged commit 32cfb4f into SchemaStore:master Aug 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

src/schemas/json/config.json has no information available for it
3 participants