Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use code-owner-self-merge fork that supports optional pinging #3521

Merged

Conversation

hyperupcall
Copy link
Member

The upstream OSS-Docs-Tools/code-owner-self-merge is useful, but I thought it was missing a feature in which it would not ping certain CODEOWNERS. This is useful when a CODEOWNER watches the repositories (for pull requests) and would recieve a notification anyways, on a PR. This is helpful when prioritizing PRs in the notification page: it will show as a notification of type "review quested" instead of "mentioned".

When ownerNoPings is configured, it looks like this:

image

@github-actions github-actions bot added ci ".github/**/*" folder is updated (auto-generated by labeler action) NodeJS NodeJS files are updated (auto-generated by labeler action) labels Jan 16, 2024
@hyperupcall hyperupcall marked this pull request as ready for review January 18, 2024 23:06
@madskristensen
Copy link
Contributor

Nice. This is so great

@hyperupcall hyperupcall changed the title Use fork of code-owner-self-merge that supports optional pinging Use code-owner-self-merge fork that supports optional pinging Jan 19, 2024
@hyperupcall hyperupcall merged commit 71d4f4c into SchemaStore:master Jan 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci ".github/**/*" folder is updated (auto-generated by labeler action) NodeJS NodeJS files are updated (auto-generated by labeler action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants