Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pyright as a subschema of PyProject #3526

Merged
merged 10 commits into from
Jan 17, 2024
Merged

Add Pyright as a subschema of PyProject #3526

merged 10 commits into from
Jan 17, 2024

Conversation

InSyncWithFoo
Copy link
Contributor

@InSyncWithFoo InSyncWithFoo commented Jan 17, 2024

Fixes #3525.

@InSyncWithFoo InSyncWithFoo marked this pull request as ready for review January 17, 2024 08:30
@InSyncWithFoo
Copy link
Contributor Author

I basically copied the whole schema from Pyright's repository, which is licensed under MIT. Any ideas how to add a copy of that license to this repository, as per the conditions?

@hyperupcall
Copy link
Member

I basically copied the whole schema from Pyright's repository, which is licensed under MIT. Any ideas how to add a copy of that license to this repository, as per the conditions?

If you add a $comment to the top level mentioning the license, i think that should be enough. I would also recommend mentioning that the file is a copy-and-pasted from the original, and the date, so we know how out of date it is. Related to #2731

@hyperupcall
Copy link
Member

hyperupcall commented Jan 17, 2024

Usually, for this kind of file, I would request for you to change the name of the file pyright.json (without the partial-) to be consistent since pyrightconfig.json is a thing. But I think it is a good call, so this addition does not get confused with the actual (more up to date) pyright schema.

You can take a look at this section of contributing.md to fix the build. Once it passes, i'll be able to merge

@InSyncWithFoo
Copy link
Contributor Author

InSyncWithFoo commented Jan 17, 2024

@hyperupcall Done (probably). Anything else before I can get better autocompletion in my IDE?

@hyperupcall
Copy link
Member

Nope, thanks!

@hyperupcall hyperupcall merged commit 2b6a63c into SchemaStore:master Jan 17, 2024
3 checks passed
madskristensen pushed a commit that referenced this pull request Jan 18, 2024
* Add "description" fields

* Add a comment for "overrides"

* Fix formatting

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add subschema for Pyright
3 participants