Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix id vs. $id in strict meta schema (#4019) #4029

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Fix id vs. $id in strict meta schema (#4019) #4029

merged 2 commits into from
Aug 30, 2024

Conversation

Vampire
Copy link
Contributor

@Vampire Vampire commented Aug 29, 2024

Fixes #4019

@github-actions GitHub Actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@EmilyGraceSeville7cf
Copy link
Contributor

Thanks for fixing this issue. 😊 LGTM

@github-actions GitHub Actions
Copy link
Contributor

Sorry @EmilyGraceSeville7cf, you don't have access to these files:

@madskristensen madskristensen merged commit e3d4865 into SchemaStore:master Aug 30, 2024
4 checks passed
@madskristensen
Copy link
Contributor

Thanks

@Vampire Vampire deleted the vampire/fix-id-in-meta branch August 30, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilyGraceSeville7cf EmilyGraceSeville7cf EmilyGraceSeville7cf approved these changes

@madskristensen madskristensen Awaiting requested review from madskristensen madskristensen is a code owner

@hyperupcall hyperupcall Awaiting requested review from hyperupcall hyperupcall is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

id vs. $id in metaschema-draft-07-unofficial-strict.json
3 participants
@Vampire @EmilyGraceSeville7cf @madskristensen