Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Drupal Recipes #4186 #4187

Merged
merged 31 commits into from
Nov 4, 2024

Conversation

marcelovani
Copy link
Contributor

Resolves #4186

This PR adds extra properties based on the latest Drupal Recipes documentation https://git.drupalcode.org/project/distributions_recipes/-/blob/1.0.x/docs/config_action_list.md

This PR is important because the schema is being used by Drupal Recipes Autocomplete extension for VS Code

This schema can also be used to generate documentation in the future.
For reference, see this Drupal issue

List of changes

  • Updated required properties for name, title, description
  • Added description for the default property, so autocompletes shows it as 'New Recipe' instead of 'drupal-recipe.json'
  • Added extra schemas based on the Drupal Recipes documentaion

Copy link
Contributor

github-actions bot commented Nov 2, 2024

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@marcelovani
Copy link
Contributor Author

I am working on the failing tests

@marcelovani
Copy link
Contributor Author

All tests passing now, please review.

@hyperupcall
Copy link
Member

Thanks! If you'd like, feel free to make a PR adding yourself to the CODEOWNERS file for drupal-recipe.json if you'd like to merge future changes yourself and be pinged on updates to the file (more info in CONTRIBUTING.md).

@hyperupcall hyperupcall merged commit 049c6d5 into SchemaStore:master Nov 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates for Drupal Recipes
2 participants