Fixes #241 #259
Fixes #241 #259
Conversation
…ault. Changed detection for group calls more accurate. Added tracking visibility status for jitsi notifications
…s, cleanup code in the NotificationBuilderUtils
|
Note of advice, if you want to have any chance that I review this PR to maybe get it merged at some point, changes should be minimal to achieve the goal, while being as upstream-merge-friendly as possible. Currently the diff is way too huge and touches lots of upstream files. You may want to read up on #250 as well for some hints. |
|
This MR incorporates all the logic that appeared in MR #241 and includes fixes for all comments. In order to improve maintainability and readability, the NotificationsUtils class was refactored. As a result, three new classes were created: NotificationBuilderUtils, NotificationCommonUtils, and NotificationUtils. This entailed changes to a number of files related to method porting. |
Chore: Resolve MR code-review.
…solve-notifications-mr
Chore/resolve notifications mr
|
Made changes: put all utils for jitsi into a separate class - JitsiNotificationsUtils. Went through the whole code - significantly reduced upstream issues. Could you please take a look at this MP? |
This MR fixes issues found in closed MR #241. In particular, the NotificationUtils class has been split, the function has been renamed from jitsiCallIntent to getCallIntent, and a new method for removing notifications from the user side - rejectNotification - has been added.