Update for thread colors #785
Conversation
BadAimWeeb
requested review from
bsansouci and
Schmavery
and removed request for
bsansouci
| ////Fern: "#67b868", | ||
| ////Cameo: "#d4a88c", | ||
| ////BrilliantRose: "#ff5ca1", | ||
| ////BilobaFlower: "#a695c7" |
There was a problem hiding this comment.
Are these the same colors with different names? This is a really breaking change...
Everything else looks great but I wonder if we can keep some of the same names?
There was a problem hiding this comment.
umm, those are some old color which have been commented. also facebook uses theme id now, so those old colors can't be used anymore.
and no, we can't keep them.
There was a problem hiding this comment.
I understand that the api has changed, but clearly some of these colors must be similar MessengerBlue vs DefaultBlue for example.. I remember the original names came from the messenger code somewhere, where did you get the new names?
I'm sure you understand that this change break anyone who currently uses this api
There was a problem hiding this comment.
I get these names from this
and yes, I understand that this change will break compatibility.
There was a problem hiding this comment.
@lequanglam you should put new ids in place of old hex colours (instead of commenting them). This way we can maintain backward compatibility.
There was a problem hiding this comment.
@ravkr I will try to make it backward-compatible, but i'm currently busy at listenMqtt's bugs.
Resolves #784