Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add papi support #8

Merged
merged 2 commits into from
Sep 29, 2023
Merged

add papi support #8

merged 2 commits into from
Sep 29, 2023

Conversation

XXY233
Copy link
Contributor

@XXY233 XXY233 commented Sep 25, 2023

No description provided.

@SchnTgaiSpock
Copy link
Owner

thx for the pr!

looks pretty good, just 3 things:

  • moving the placeholder-api-support toggle to options instead of waila
  • using javax @Nonnull and @Nullable annotations for consistency instead of jetbrains
  • in onPlaceholderRequest, i think you can use getString instead of getBoolean + `String.valueOf``

@XXY233
Copy link
Contributor Author

XXY233 commented Sep 27, 2023

Thanks for the review, I've addressed all the requested changes :)

@SchnTgaiSpock SchnTgaiSpock merged commit b6dc2d5 into SchnTgaiSpock:master Sep 29, 2023
@XXY233 XXY233 deleted the placeholder-api-support branch September 29, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XXY233 @SchnTgaiSpock