Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs that changs in PR #404 were reverted in PR #411 #412

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

chuan-wang
Copy link
Member

Hi @kedhammar , I just noticed that part of my changes in PR #404 were reverted in your latest PR #411 . Did you make changes on an out-of-date version of TACA?

Copy link
Member

@alneberg alneberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think you're correct @chuan-wang.

Copy link

@kedhammar kedhammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! I guess I must've slipped up in the versioning 🤔

@chuan-wang
Copy link
Member Author

Sorry! I guess I must've slipped up in the versioning 🤔

No problem! It is a very minor change anyway!

@chuan-wang chuan-wang merged commit 4617a61 into SciLifeLab:master Feb 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants