Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial setup for element aviti #432

Merged
merged 232 commits into from
Oct 25, 2024
Merged

Initial setup for element aviti #432

merged 232 commits into from
Oct 25, 2024

Conversation

ssjunnebo
Copy link

No description provided.

@ssjunnebo ssjunnebo added the WIP label Aug 29, 2024
@ssjunnebo ssjunnebo marked this pull request as draft August 29, 2024 08:22
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 45.50409% with 400 lines in your changes missing coverage. Please review.

Project coverage is 29.52%. Comparing base (6390b97) to head (81ea936).
Report is 233 commits behind head on master.

Files with missing lines Patch % Lines
taca/element/Element_Runs.py 46.51% 315 Missing ⚠️
taca/analysis/analysis_element.py 44.44% 60 Missing ⚠️
taca/utils/statusdb.py 27.27% 16 Missing ⚠️
taca/analysis/cli.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
+ Coverage   26.57%   29.52%   +2.95%     
==========================================
  Files          28       31       +3     
  Lines        3959     4691     +732     
==========================================
+ Hits         1052     1385     +333     
- Misses       2907     3306     +399     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alneberg alneberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

ssjunnebo and others added 4 commits October 25, 2024 08:33
Fix issue with redundant PhiX record
Improvements on test CI, introduction of prettier functional tests and minor bugfixes
@ssjunnebo ssjunnebo merged commit 49e76bc into SciLifeLab:master Oct 25, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants