Implement continous integration for linting and formatting and adress issues #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
separate user-vs-dev requirements and add pytest and codecov to ci make pkg comparison case-insensitive
apply pytest-cov, try different codecov workflow try new codecov action correct syntax
aanil
reviewed
Jul 16, 2024
aanil
reviewed
Jul 16, 2024
aanil
reviewed
Jul 16, 2024
aanil
reviewed
Aug 5, 2024
Co-authored-by: Anandashankar Anil <[email protected]>
alneberg
reviewed
Aug 23, 2024
alneberg
reviewed
Aug 23, 2024
alneberg
reviewed
Aug 23, 2024
tests/test_entities.py
Outdated
| "requests.Session.get", | ||
| return_value=Mock(content=self.reagentkit_xml, status_code=200), | ||
| ): | ||
| assert r.name == "regaentkitname" |
There was a problem hiding this comment.
Tempting to want to change this, but I don't know where it origins from
There was a problem hiding this comment.
I just replace regaentwith reagent, 3 hits repo wide.
alneberg
reviewed
Aug 23, 2024
alneberg
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented CI-practices based on repo SciLifeLab/scilifelab_epps and addressed all linting and formatting issues.