Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spiking_neural_systems.md #729

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

jbrea
Copy link
Contributor

@jbrea jbrea commented Mar 6, 2024

It looks odd, when the membrane potential in an integrate-and-fire neuron overshoots the threshold.

Btw: I find it convenient to use ComponentArrays for parameters, such that I can write e.g. integrator.p.Vth instead of integrator.p[4], but I didn't apply this change here, as it would introduce a new dependency.

It looks odd, when the membrane potential in an integrate-and-fire neuron overshoots the threshold.

Btw: I find it convenient to use `ComponentArrays` for parameters, such that I can write e.g. `integrator.p.Vth` instead of `integrator.p[4]`, but I didn't apply this change here, as it would introduce a new dependency.
@ChrisRackauckas
Copy link
Member

I think it would be fine to introduce the dependency. I would say it's good style and nice to show in an example.

@ChrisRackauckas ChrisRackauckas merged commit 9fd021d into SciML:master Mar 8, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants