tearing: Heuristically attempt to assign equations with single solvab… #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le first This changes to tearing to give priority to any equation <-> variable pairs where a particular equation only has one matchable variable. These are easy, becuse, if the equation is part of the final matching at all, we know which variable they need to be matched to and by matching them first, we can avoid accidentally assigning these variables to another equation, which would necessarily increase the number of torn states.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…le first
This changes to tearing to give priority to any equation <-> variable pairs where a particular equation only has one matchable variable. These are easy, becuse, if the equation is part of the final matching at all, we know which variable they need to be matched to and by matching them first, we can avoid accidentally assigning these variables to another equation, which would necessarily increase the number of torn states.