New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override defaults when setting initial conditions with mapped unknowns(sys) #3028

Merged

ChrisRackauckas merged 5 commits into SciML:master from hersle:fix_ics_unknowns

Sep 8, 2024

Contributor

hersle commented Sep 8, 2024

This seems to be a relatively simple way to fix #3025.

Checklist

Appropriate tests were added
Any code changes were done in a way that does not break public API
All documentation related to code changes were updated
The new code follows the
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Any new documentation only uses public API

hersle added 5 commits

September 8, 2024 12:03


          Prioritize filtered_u0 deferral when creating initialization system

f156381


          Test that defaults are overridden when sys is initialized with map fr…

d648bc1

…om unknowns(sys)


          Fix small inconsistencies

aa3f485


          filtered_u0 cannot be a Pair here

a4a5ccf


          Format

937ef53

ChrisRackauckas merged commit 741ade3 into SciML:master

22 of 23 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet