Clean up generate_initializesystem() #3051
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #3050, I found
generate_initializesystem()
a little hard to follow. I thought I could try to clean it up a little, after it has accumulated several fixes recently.Please feel free to ignore this if it is not helpful. I know @AayushSabharwal is working on parameter initialization, so I wouldn't want this merged before if it clutters that!
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.