Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs remove extra returns from loss and extra args from callback #1128

Merged
merged 26 commits into from
Nov 5, 2024

Conversation

Vaibhavdixit02
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@Vaibhavdixit02
Copy link
Member Author

Not sure what the failure is now. It doesn't show any errors in the logs but a segmentation fault at the end?

@ChrisRackauckas
Copy link
Member

Is it just the SDE control example? Did you isolate it locally?

@@ -45,7 +46,8 @@ Enzyme = "0.12, 0.13"
Flux = "0.14"
ForwardDiff = "0.10"
IterTools = "1"
Lux = "1"
MLUtils = "0.4"
Lux = "0.5.7, 1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why pull back Lux?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I think it showed up in a rebase conflict. Doesn't need to be held back

docs/Project.toml Outdated Show resolved Hide resolved
@ChrisRackauckas
Copy link
Member

The segfault is fixed.

@ChrisRackauckas ChrisRackauckas merged commit c602d13 into master Nov 5, 2024
13 of 17 checks passed
@ChrisRackauckas ChrisRackauckas deleted the docsoptv4 branch November 5, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants