Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid needing adjoints of SciMLStructures' constructor #1135

Merged
merged 12 commits into from
Nov 8, 2024

Conversation

DhairyaLGandhi
Copy link
Member

@DhairyaLGandhi DhairyaLGandhi commented Oct 21, 2024

Fixes SciML/SciMLStructures.jl#30

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review November 8, 2024 12:55
@DhairyaLGandhi
Copy link
Member Author

Core 1 failure is related to [email protected], tests pass with v2.58.1 https://github.com/SciML/SciMLSensitivity.jl/actions/runs/11742803980/job/32714279824

The new Core 6 failure also seems unrelated?

@ChrisRackauckas
Copy link
Member

@AayushSabharwal

@AayushSabharwal
Copy link
Member

Oops 😅 SciML/SciMLBase.jl#855

@ChrisRackauckas ChrisRackauckas merged commit 9143ea7 into master Nov 8, 2024
12 of 17 checks passed
@ChrisRackauckas ChrisRackauckas deleted the dg/nnrev2 branch November 8, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradient on a custom struct doesn't work
3 participants