3.11.1.mergeback #6273
Merged
3.11.1.mergeback #6273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PoC monkeypatch precision. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add FUTURE flag. * FutureWarning. * Corrected behaviour and added tests. * Corrected behaviour and added tests. * What's New entry. * Make sensitive to cf-units version. * Further test improvements. * Clearer FutureWarning text. * Use a cf-units subclass instead. * Rename _IrisUnit to Unit. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* pin dask <2024.9 * update lockfiles * update for pypi * add whatsnew, fix tests * skip failing doctests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6273 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 88 88
Lines 23385 23385
Branches 4357 4357
=======================================
Hits 21012 21012
Misses 1646 1646
Partials 727 727 ☔ View full report in Codecov by Sentry. |
pp-mo
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
OK I think it finally makes sense to me now !
It seems a peculiarly complicated way to do it, which we never actually did before
(e.g. #6104 #5921 #5794 ).
However the actual resulting changes are exactly those (very few) you expect
And I guess the result makes a safer basis for any possible future need to merge again between the 2 branches
I think on advice of @trexfeathers ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the PR into main using a MERGE COMMIT (not a squash commit)